[GitHub] [flink] 1996fanrui commented on a diff in pull request #21353: [FLINK-30100][checkpointing] Remove the unused CheckpointFailureReason

[GitBox <gi...@apache.org>]

1996fanrui commented on code in PR #21353:
URL: https://github.com/apache/flink/pull/21353#discussion_r1030484528


##########
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorTest.java:
##########
@@ -3837,14 +3829,6 @@ public void testBaseLocationsNotInitialized() throws Exception {
                         .addJobVertex(jobVertexID)
                         .setTransitToRunning(false)
                         .build(EXECUTOR_RESOURCE.getExecutor());
-        CheckpointCoordinator checkpointCoordinator =
-                new CheckpointCoordinatorBuilder()
-                        .setCheckpointCoordinatorConfiguration(
-                                CheckpointCoordinatorConfiguration.builder()
-                                        .setCheckpointInterval(Long.MAX_VALUE)
-                                        .build())
-                        .setCheckpointStorage(new FsStateBackend(checkpointDir.toURI()))
-                        .build(graph);

Review Comment:
   You are right, It's my mistake.  I see this checkpointCoordinator isn't used, so removed it. 
   
   It's covered, and I removed the `CheckpointCoordinator checkpointCoordinator =` due to it's not necessary.
   
   BTW, I did some extra work in this PR during fix this comment.
   
   I migrate checkpoint coordinator related tests to junit5 in the 3rd commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org