You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2013/08/27 07:56:21 UTC
[jclouds] Skip testDirectory on S3 (#129)
This test cannot succeed due to the way directories are implemented as
prefix pseudo-files in S3.
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds skip-s3-test-directory
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/129
-- Commit Summary --
* Skip testDirectory on S3
-- File Changes --
M apis/s3/src/test/java/org/jclouds/s3/blobstore/integration/S3ContainerIntegrationLiveTest.java (8)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/129.patch
https://github.com/jclouds/jclouds/pull/129.diff
Re: [jclouds] Skip testDirectory on S3 (#129)
Posted by Andrew Phillips <no...@github.com>.
> @@ -31,4 +32,11 @@ public S3ContainerIntegrationLiveTest() {
> provider = "s3";
> BaseBlobStoreIntegrationTest.SANITY_CHECK_RETURNED_BUCKET_NAME = true;
> }
> +
> + @Override
> + public void testDirectory() throws InterruptedException {
> + // S3 does not support directories, rather it supports prefixes which look
> + // like directories. We should filter out the fake RELATIVE_PATH.
> Long story short, this test can succeed.
Thanks for explaining!
+1 - looks good to go for me.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/129/files#r6019384
Re: [jclouds] Skip testDirectory on S3 (#129)
Posted by Andrew Phillips <no...@github.com>.
> @@ -31,4 +32,11 @@ public S3ContainerIntegrationLiveTest() {
> provider = "s3";
> BaseBlobStoreIntegrationTest.SANITY_CHECK_RETURNED_BUCKET_NAME = true;
> }
> +
> + @Override
> + public void testDirectory() throws InterruptedException {
> + // S3 does not support directories, rather it supports prefixes which look
> + // like directories. We should filter out the fake RELATIVE_PATH.
In the test or in the code? Is this a test that ever _could_ succeed? If not, should the SkipException be something like "not supported"?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/129/files#r6007207
Re: [jclouds] Skip testDirectory on S3 (#129)
Posted by Andrew Phillips <no...@github.com>.
One small question, but otherwise +1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/129#issuecomment-23343307
Re: [jclouds] Skip testDirectory on S3 (#129)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #637](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/637/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/129#issuecomment-23315898
Re: [jclouds] Skip testDirectory on S3 (#129)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #177](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/177/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/129#issuecomment-23316047
Re: [jclouds] Skip testDirectory on S3 (#129)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #349](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/349/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/129#issuecomment-23315824
Re: [jclouds] Skip testDirectory on S3 (#129)
Posted by Andrew Gaul <no...@github.com>.
> @@ -31,4 +32,11 @@ public S3ContainerIntegrationLiveTest() {
> provider = "s3";
> BaseBlobStoreIntegrationTest.SANITY_CHECK_RETURNED_BUCKET_NAME = true;
> }
> +
> + @Override
> + public void testDirectory() throws InterruptedException {
> + // S3 does not support directories, rather it supports prefixes which look
> + // like directories. We should filter out the fake RELATIVE_PATH.
We should change jclouds logic to make S3's fake directories act more like the jclouds concept of directories. Consider mkdir -p a/b/c and ls a/ . jclouds will return a, a/b, and a/b/c in this situation since it matches based on the prefix. ls a/b/ returns a/b and a/b/c . I think we should match other providers and return b in the first situation and b in the second. Long story short, this test can succeed.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/129/files#r6016367