You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by gi...@apache.org on 2019/03/26 14:09:03 UTC
[beam] branch asf-site updated: Publishing website 2019/03/26
14:08:54 at commit 1eb2164
This is an automated email from the ASF dual-hosted git repository.
git-site-role pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 1f08e9e Publishing website 2019/03/26 14:08:54 at commit 1eb2164
1f08e9e is described below
commit 1f08e9e9fa5e138ed15cbfdc53210366fc9f1ff5
Author: jenkins <bu...@apache.org>
AuthorDate: Tue Mar 26 14:08:54 2019 +0000
Publishing website 2019/03/26 14:08:54 at commit 1eb2164
---
website/generated-content/contribute/committer-guide/index.html | 1 +
1 file changed, 1 insertion(+)
diff --git a/website/generated-content/contribute/committer-guide/index.html b/website/generated-content/contribute/committer-guide/index.html
index cd5ba82..b72a08d 100644
--- a/website/generated-content/contribute/committer-guide/index.html
+++ b/website/generated-content/contribute/committer-guide/index.html
@@ -255,6 +255,7 @@ but committer may absorb some extra effort for new contributors)</li>
<li>It is OK to keep separate commits for different logical pieces of the code, if they make reviewing and revisiting code easier</li>
<li>Making commits isolated is a good practice, authors should be able to relatively easily split the PR upon reviewer’s request</li>
<li>Generally, every commit should compile and pass tests.</li>
+ <li>Avoid keeping in history formatting messages such as checkstyle or spotless fixes. Squash such commits with previous one.</li>
</ul>
<h2 id="always-get-to-lgtm-looks-good-to-me">Always get to LGTM (“Looks good to me!”)</h2>