You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Diogo Guerra (JIRA)" <ji...@apache.org> on 2015/08/29 03:02:45 UTC

[jira] [Commented] (CASSANDRA-8565) opinion on refactoring ListenableFuture to Java 8 CompletableFuture

    [ https://issues.apache.org/jira/browse/CASSANDRA-8565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720864#comment-14720864 ] 

Diogo Guerra commented on CASSANDRA-8565:
-----------------------------------------

It would be interesting to revisit this suggestion

> opinion on refactoring ListenableFuture to Java 8 CompletableFuture
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-8565
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8565
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Yu Lin
>            Priority: Minor
>
> Hi, I'm doing research on new concurrent constructs in Java 8. I found CompletableFuture in Java 8 has the same functionality as Guava ListenableFuture. But CompletableFuture is much nicer because it comes together with Lambda expression in Java 8, and it is monadic, which makes the code more readable and cleaner. Also, it provides more ways to compose different tasks. Therefore, using CompletableFuture instead of ListenableFuture is better for future extension and maintenance of the code.
> I also created a pull request on the Github repo and refactored one ListenableFuture instance, so you can see the diff (you don't have to apply that patch): 
> https://github.com/apache/cassandra/pull/50
> I'm just wondering your opinion on this kind of refactoring (or migrating the code from Java 7 to Java 8). Do you think the refactoring is useful? Do you have any plan to use Java 8?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)