[GitHub] [echarts] sirAbramstone commented on pull request #18259: feat(tooltip): support relative length units for font-size. close #18253

["sirAbramstone (via GitHub)" <gi...@apache.org>]

sirAbramstone commented on PR #18259:
URL: https://github.com/apache/echarts/pull/18259#issuecomment-1437391057

   > I think this should be implemented in [zrender src/graphic/Text.ts](https://github.com/ecomfe/zrender/blob/9197e0573daaedb2344a69acc83b4dd03d070615/src/graphic/Text.ts#L917). The test case should be added at [Text.test.ts](https://github.com/ecomfe/zrender/blob/9197e0573daaedb2344a69acc83b4dd03d070615/test/ut/spec/graphic/Text.test.ts).
   
   Hi, Ovilia! As I understood, the method `parseFontSize` that you attached is only used for the tooltip if its `renderMode` is equal to 'richText' (and in this case relative units no longer had any problems with support). When `renderMode` is 'html', the font-string is built using the methods I fixed and has nothing to do with zrender lib. Correct me if I'm wrong.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org