You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2017/10/31 22:31:17 UTC
[Bug 7491] New: Improve SA test suite by moving to Test::More
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7491
Bug ID: 7491
Summary: Improve SA test suite by moving to Test::More
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: Regression Tests
Assignee: dev@spamassassin.apache.org
Reporter: toddr@cpanel.net
Target Milestone: Undefined
We are planning to submit several patches to the SA project. This is my first
attempt.
I propose moving the test suite from using Test to using Test::More, which has
been available in core perl since 5.6.2. SA appears to not function below 5.8,
so this doesn't really add any significant deps.
This patch has several benefits:
1. It provides better TAP output explaining why tests were skipped via the use
of skip_all
2. It opens up the opportunity for skip blocks in code so you don't need to
have varying test counts.
3. It gets rid of a significant number of BEGIN blocks (though some had to be
kept to retain original behavior)
4. It makes additional modernization (use vars) of the code possible.
Patch pending.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7491] Improve SA test suite by moving to Test::More
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7491
Todd Rinaldo <to...@cpanel.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |toddr@cpanel.net
--- Comment #1 from Todd Rinaldo <to...@cpanel.net> ---
Created attachment 5469
--> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5469&action=edit
Patch for proposed change.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7491] Improve SA test suite by moving to Test::More
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7491
Kevin A. McGrail <km...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail@apache.org
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from Kevin A. McGrail <km...@apache.org> ---
Todd, any input on https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7163 for
running through the tests faster?
3.4:
Committed revision 1823142.
trunk:
Committed revision 1823143.
--
You are receiving this mail because:
You are the assignee for the bug.