You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/11/30 04:32:43 UTC

[GitHub] [inlong] ZuoFengZhang opened a new pull request, #6686: [Script] The bin/init-config.sh compatible with MacOS

ZuoFengZhang opened a new pull request, #6686:
URL: https://github.com/apache/inlong/pull/6686

   ### The bin/init-config.sh compatible with MacOS
   
   [Script] The bin/init-config.sh compatible with MacOS #6685 
   
   ### Motivation
   
   Modify the sed command using in MacOS
   
   ### Modifications
   
   when the init-config.sh script executes the sed command, it is necessary to first determine the current OS type and perform respective adaptations. The `sed` command is used for substitution in MacOS,
   
   ```shell
   sed -i ...
   ```
   
    while GNU syntax can be used in Linux.
   
   ```shell
   sed -i '' ...
   ```
   
   
   
   ### Verifying this change
   
   *(Please pick either of the following options)*
   
   - [x] This change is a trivial rework/code cleanup without any test coverage.
   
   - [ ] This change is already covered by existing tests, such as:
     *(please describe tests)*
   
   - [ ] This change added tests and can be verified as follows:
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] dockerzhang merged pull request #6686: [INLONG-6685][Script] The bin/init-config.sh script compatible with MacOS

Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #6686:
URL: https://github.com/apache/inlong/pull/6686


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org