You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by gi...@git.apache.org on 2017/08/17 07:25:54 UTC

[GitHub] tkb77 commented on issue #671: Should authParamsString for Authentication support another format ?

tkb77 commented on issue #671: Should authParamsString for Authentication support another format ?
URL: https://github.com/apache/incubator-pulsar/issues/671#issuecomment-322990957
 
 
   
   My name is Yuta Takaba, a software engineer at Yahoo Japan Corporation.
   Please call me **TKB**!
   Anyway, I try to address this issue by the following:
   
   1: Adding `configure(String authParamString)` to [Authentication](https://github.com/apache/incubator-pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/api/Authentication.java) instead of making new interface for simplicity
   
   2: Support JSON for configure.
      - Because, JSON is popular, widely used.
      - For keeping compatibility, using current parsing logic(separated by ?:? and ?,?)  if an argument is not JSON.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services