[GitHub] [airflow] jedcunningham commented on a diff in pull request #22092: Find Pod Before Cleanup In KubernetesPodOperator Execution

[GitBox <gi...@apache.org>]

jedcunningham commented on code in PR #22092:
URL: https://github.com/apache/airflow/pull/22092#discussion_r888435654


##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -428,16 +430,18 @@ def cleanup(self, pod: k8s.V1Pod, remote_pod: k8s.V1Pod):
                 with _suppress(Exception):
                     for event in self.pod_manager.read_pod_events(pod).items:
                         self.log.error("Pod Event: %s - %s", event.reason, event.message)
-            with _suppress(Exception):
-                self.process_pod_deletion(pod)
+            if remote_pod is not None:

Review Comment:
   I'm not sure if we care, but if the create succeeds but the find fails, we can leave the pod with this approach.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org