You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ashashwat <gi...@git.apache.org> on 2018/01/30 10:52:26 UTC
[GitHub] spark pull request #20436: [SPARK-23174][DOC][PYTHON] python code style chec...
GitHub user ashashwat opened a pull request:
https://github.com/apache/spark/pull/20436
[SPARK-23174][DOC][PYTHON] python code style checker update fix.
## What changes were proposed in this pull request?
Consistency in style, grammar and removal of extraneous characters.
## How was this patch tested?
Manually as this is a doc change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ashashwat/spark SPARK-23174
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20436.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20436
----
commit 78cb070a88bc61a3117ecde25a25ab40157ccfe1
Author: Shashwat Anand <me...@...>
Date: 2018-01-30T10:45:01Z
[SPARK-23174][DOC][PYTHON] python code style checker update fix.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20436: [MINOR] Fix typos in dev/* scripts.
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20436
**[Test build #86816 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86816/testReport)** for PR 20436 at commit [`78cb070`](https://github.com/apache/spark/commit/78cb070a88bc61a3117ecde25a25ab40157ccfe1).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20436: [MINOR] Fix typos in dev/* scripts.
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20436
Merged to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20436: [SPARK-23174][DOC][PYTHON] python code style checker upd...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20436
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20436: [MINOR] Fix typos in dev/* scripts.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20436
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20436: [MINOR] Fix typos in dev/* scripts.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20436
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86828/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20436: [SPARK-23174][DOC][PYTHON] python code style checker upd...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20436
@ashashwat, thanks. Let's update the PR title to something like .. `[MINOR] Fix typos in dev/* scripts`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20436: [MINOR] Fix typos in dev/* scripts.
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20436#discussion_r164758616
--- Diff: dev/lint-python ---
@@ -60,9 +60,9 @@ export "PYLINT_HOME=$PYTHONPATH"
export "PATH=$PYTHONPATH:$PATH"
# There is no need to write this output to a file
-#+ first, but we do so so that the check status can
-#+ be output before the report, like with the
-#+ scalastyle and RAT checks.
--- End diff --
Wow, thank you so much.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20436: [SPARK-23174][DOC][PYTHON] python code style checker upd...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20436
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20436: [MINOR] Fix typos in dev/* scripts.
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20436#discussion_r164751630
--- Diff: dev/lint-python ---
@@ -60,9 +60,9 @@ export "PYLINT_HOME=$PYTHONPATH"
export "PATH=$PYTHONPATH:$PATH"
# There is no need to write this output to a file
-#+ first, but we do so so that the check status can
-#+ be output before the report, like with the
-#+ scalastyle and RAT checks.
--- End diff --
Hmm .. @nchammas, some of these seem added by you a long ago. Could you take a look for this one please? I think I am not aware of this. Wonder if we can just remove those.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20436: [SPARK-23174][DOC][PYTHON] python code style checker upd...
Posted by ashashwat <gi...@git.apache.org>.
Github user ashashwat commented on the issue:
https://github.com/apache/spark/pull/20436
@HyukjinKwon Let me go ahead and check all the scripts for similar instances or typos.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20436: [SPARK-23174][DOC][PYTHON] python code style checker upd...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20436
I would rather suggest to fix these together in the followup already open, 20432 or find out more typos while we are here.
Can you take another look for other scripts and check if there are similar instances or typos? It'd be nicer if we fix them in batch.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20436: [SPARK-23174][DOC][PYTHON] python code style checker upd...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20436
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20436: [SPARK-23174][DOC][PYTHON] python code style checker upd...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20436
**[Test build #86821 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86821/testReport)** for PR 20436 at commit [`d2d157d`](https://github.com/apache/spark/commit/d2d157dac81247bba71d04c2118d2bb60fe2148b).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20436: [MINOR] Fix typos in dev/* scripts.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20436
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20436: [MINOR] Fix typos in dev/* scripts.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20436
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20436: [SPARK-23174][DOC][PYTHON] python code style checker upd...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20436
**[Test build #86816 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86816/testReport)** for PR 20436 at commit [`78cb070`](https://github.com/apache/spark/commit/78cb070a88bc61a3117ecde25a25ab40157ccfe1).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20436: [MINOR] Fix typos in dev/* scripts.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20436
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86821/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20436: [MINOR] Fix typos in dev/* scripts.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20436
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20436: [SPARK-23174][DOC][PYTHON] python code style chec...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20436#discussion_r164706951
--- Diff: dev/lint-python ---
@@ -60,9 +60,9 @@ export "PYLINT_HOME=$PYTHONPATH"
export "PATH=$PYTHONPATH:$PATH"
# There is no need to write this output to a file
-#+ first, but we do so so that the check status can
-#+ be output before the report, like with the
-#+ scalastyle and RAT checks.
--- End diff --
Ah, this wasn't from SPARK-23174 tho.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20436: [MINOR] Fix typos in dev/* scripts.
Posted by ashashwat <gi...@git.apache.org>.
Github user ashashwat commented on a diff in the pull request:
https://github.com/apache/spark/pull/20436#discussion_r164749320
--- Diff: dev/lint-python ---
@@ -60,9 +60,9 @@ export "PYLINT_HOME=$PYTHONPATH"
export "PATH=$PYTHONPATH:$PATH"
# There is no need to write this output to a file
-#+ first, but we do so so that the check status can
-#+ be output before the report, like with the
-#+ scalastyle and RAT checks.
--- End diff --
Is that so? We have 100 character limit on a single line according to the style guide. Maybe all 4 lines could be rearranged?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20436: [MINOR] Fix typos in dev/* scripts.
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20436#discussion_r164757437
--- Diff: dev/lint-python ---
@@ -60,9 +60,9 @@ export "PYLINT_HOME=$PYTHONPATH"
export "PATH=$PYTHONPATH:$PATH"
# There is no need to write this output to a file
-#+ first, but we do so so that the check status can
-#+ be output before the report, like with the
-#+ scalastyle and RAT checks.
--- End diff --
The `#+` convention is something I picked up from [the Linux Documentation Project](http://tldp.org/LDP/abs/html/here-docs.html#COMMENTBLOCK), if that's what you're referring to. You can safely do away with it and just have the `#`.
It was a "phase". I'm over it now... 😆
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20436: [SPARK-23174][DOC][PYTHON] python code style chec...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20436#discussion_r164747258
--- Diff: dev/lint-python ---
@@ -60,9 +60,9 @@ export "PYLINT_HOME=$PYTHONPATH"
export "PATH=$PYTHONPATH:$PATH"
# There is no need to write this output to a file
-#+ first, but we do so so that the check status can
-#+ be output before the report, like with the
-#+ scalastyle and RAT checks.
--- End diff --
Hmmm .. seems this indicates line continuation and intentional .. ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20436: [MINOR] Fix typos in dev/* scripts.
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20436
**[Test build #86821 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86821/testReport)** for PR 20436 at commit [`d2d157d`](https://github.com/apache/spark/commit/d2d157dac81247bba71d04c2118d2bb60fe2148b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20436: [MINOR] Fix typos in dev/* scripts.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20436
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86816/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20436: [SPARK-23174][DOC][PYTHON] python code style checker upd...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20436
**[Test build #86828 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86828/testReport)** for PR 20436 at commit [`0a09dcb`](https://github.com/apache/spark/commit/0a09dcb4ac012b8ec8a5833e1e08e0a678b70302).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20436: [MINOR] Fix typos in dev/* scripts.
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20436
**[Test build #86828 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86828/testReport)** for PR 20436 at commit [`0a09dcb`](https://github.com/apache/spark/commit/0a09dcb4ac012b8ec8a5833e1e08e0a678b70302).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org