You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Tamás Cservenák (Jira)" <ji...@apache.org> on 2022/07/16 10:28:00 UTC
[jira] [Comment Edited] (MASSEMBLY-969) Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567461#comment-17567461 ]
Tamás Cservenák edited comment on MASSEMBLY-969 at 7/16/22 10:27 AM:
---------------------------------------------------------------------
Summary: problem is MSHARED-1104 in shared component, this fixes it: [https://github.com/apache/maven-common-artifact-filters/pull/29]
Solution for m-assembly-p is update (once released) the shared component (and added IT): [https://github.com/apache/maven-assembly-plugin/pull/83]
was (Author: cstamas):
Summary: problem is in shared component, this fixes it: [https://github.com/apache/maven-common-artifact-filters/pull/29]
Solution for m-assembly-p is update (once released) the shared component (and added IT): https://github.com/apache/maven-assembly-plugin/pull/83
> Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
> ---------------------------------------------------------
>
> Key: MASSEMBLY-969
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-969
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: dependencySet
> Affects Versions: 3.4.0, 3.4.1
> Environment: Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
> Java version: 17.0.3, vendor: BellSoft
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.4.0-122-generic", arch: "amd64", family: "unix"
> Reporter: Per Nyfelt
> Assignee: Tamás Cservenák
> Priority: Critical
> Fix For: 3.4.2
>
> Attachments: assembly.xml, pom.xml
>
>
> In 3.3.0 i can do the following to get the java fx base jar + the platform specific jar into one directory (i have 3 similar dependency sets for each platform so I can set the module-path to that directory depending on the os):
> <dependencySet>
> <unpack>false</unpack>
> <scope>runtime</scope>
> <outputDirectory>lib/linux</outputDirectory>
> <useProjectArtifact>false</useProjectArtifact>
> <includes>
> <include>org.openjfx:javafx-base</include>
> <include>org.openjfx:javafx-controls</include>
> <include>org.openjfx:javafx-media</include>
> <include>org.openjfx:javafx-web</include>
> <include>org.openjfx:javafx-swing</include>
> <include>org.openjfx:javafx-graphics:jar:linux</include>
> </includes>
> <excludes>
> <exclude>org.openjfx:javafx-base:jar:mac</exclude>
> <exclude>org.openjfx:javafx-base:jar:win</exclude>
> <exclude>org.openjfx:javafx-controls:jar:mac</exclude>
> <exclude>org.openjfx:javafx-controls:jar:win</exclude>
> <exclude>org.openjfx:javafx-media:jar:mac</exclude>
> <exclude>org.openjfx:javafx-media:jar:win</exclude>
> <exclude>org.openjfx:javafx-web:jar:mac</exclude>
> <exclude>org.openjfx:javafx-web:jar:win</exclude>
> <exclude>org.openjfx:javafx-swing:jar:mac</exclude>
> <exclude>org.openjfx:javafx-swing:jar:win</exclude>
> </excludes>
> </dependencySet>
>
> in 3.3.0 this gives me the following jars:
> javafx-base-18.0.1.jar
> javafx-controls-18.0.1-linux.jar
> javafx-media-18.0.1-linux.jar
> javafx-web-18.0.1.jar
> javafx-base-18.0.1-linux.jar
> javafx-graphics-18.0.1-linux.jar
> javafx-swing-18.0.1.jar
> javafx-web-18.0.1-linux.jar
> javafx-controls-18.0.1.jar
> javafx-media-18.0.1.jar
> javafx-swing-18.0.1-linux.jar
> However when using the 3.4.1 (and 3.4.0) version of the assembly plugin i get ALL of the jar i.e.
> javafx-base-18.0.1.jar
> javafx-base-18.0.1-linux.jar
> javafx-base-18.0.1-mac.jar
> javafx-base-18.0.1-win.jar
> javafx-controls-18.0.1.jar
> javafx-controls-18.0.1-linux.jar
> javafx-controls-18.0.1-mac.jar
> javafx-controls-18.0.1-win.jar
> javafx-media-18.0.1.jar
> javafx-media-18.0.1-linux.jar
> javafx-media-18.0.1-mac.jar
> javafx-media-18.0.1-win.jar
> javafx-swing-18.0.1.jar
> javafx-swing-18.0.1-linux.jar
> javafx-swing-18.0.1-mac.jar
> javafx-swing-18.0.1-win.jar
> javafx-web-18.0.1.jar
> javafx-web-18.0.1-linux.jar
> javafx-web-18.0.1-mac.jar
> javafx-web-18.0.1-win.jar
>
> The assembly plugin also complains about this:
> [WARNING] The following patterns were never triggered in this artifact inclusion filter:
> o 'org.openjfx:javafx-graphics:jar:linux'
> [WARNING] The following patterns were never triggered in this artifact exclusion filter:
> o 'org.openjfx:javafx-base:jar:mac'
> o 'org.openjfx:javafx-base:jar:win'
> o 'org.openjfx:javafx-controls:jar:mac'
> o 'org.openjfx:javafx-controls:jar:win'
> o 'org.openjfx:javafx-media:jar:mac'
> o 'org.openjfx:javafx-media:jar:win'
> o 'org.openjfx:javafx-web:jar:mac'
> o 'org.openjfx:javafx-web:jar:win'
> o 'org.openjfx:javafx-swing:jar:mac'
> o 'org.openjfx:javafx-swing:jar:win'
> I think that this is either a bug in the code or the documentation for how to combine inclusions and exclusions to get the desired effect. The full pom.xml and assembly.xml is attached for reference.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)