You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/19 10:22:20 UTC
[GitHub] [pulsar] hapihu opened a new pull request #11715: [#11714][spelling mistakes]fix spelling mistakes for doc
hapihu opened a new pull request #11715:
URL: https://github.com/apache/pulsar/pull/11715
There are some spelling mistakes in the document.
```bash
site2/docs/security-jwt.md:260: forwared ==> forwarded
site2/docs/security-kerberos.md:196: preform ==> perform
site2/docs/security-kerberos.md:221: comparision ==> comparison
site2/docs/security-kerberos.md:241: comparision ==> comparison
site2/docs/helm-overview.md:13: compoments ==> components
site2/docs/helm-overview.md:13: seperately ==> separately
site2/docs/helm-overview.md:92: conciously ==> consciously
site2/docs/security-athenz.md:44: encrption ==> encryption
site2/docs/client-libraries-websocket.md:72: Broswer ==> Browser
site2/docs/security-authorization.md:40: creats ==> creates
site2/docs/functions-develop.md:1097: refered ==> referred
site2/docs/developing-binary-protocol.md:415: retreive ==> retrieve
site2/docs/security-tls-transport.md:81: creat ==> create
site2/docs/administration-pulsar-manager.md:129: PostgresSQL ==> postgresql
site2/docs/administration-pulsar-manager.md:144: genrated ==> generated
site2/docs/administration-pulsar-manager.md:145: genrated ==> generated
site2/docs/administration-pulsar-manager.md:150: PostgresSQL ==> postgresql
site2/docs/administration-pulsar-manager.md:165: genrated ==> generated
site2/docs/administration-pulsar-manager.md:170: PostgresSQL ==> postgresql
site2/docs/deploy-bare-metal.md:171: exsiting ==> existing
site2/docs/deploy-bare-metal.md:375: succesfully ==> successfully
site2/docs/client-libraries-java.md:594: follwoing ==> following
site2/docs/client-libraries-java.md:627: follwoing ==> following
site2/docs/client-libraries-java.md:637: follwoing ==> following
site2/docs/security-tls-keystore.md:124: interal ==> internal
site2/docs/security-tls-keystore.md:229: interal ==> internal
site2/docs/concepts-messaging.md:522: dicates ==> dictates
site2/docs/administration-dashboard.md:54: explicitely ==> explicitly
site2/docs/administration-load-balance.md:118: avaliable ==> available
site2/docs/reference-pulsar-admin.md:2426: garanteed ==> guaranteed
site2/docs/reference-pulsar-admin.md:2620: specifed ==> specified
site2/docs/reference-configuration.md:59: readd ==> read
site2/docs/reference-configuration.md:100: ture ==> true
site2/docs/reference-configuration.md:247: implementatation ==> implementation
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hapihu commented on pull request #11715: [ISSUE 11714][DOC][spelling mistakes]fix spelling mistakes for doc
Posted by GitBox <gi...@apache.org>.
hapihu commented on pull request #11715:
URL: https://github.com/apache/pulsar/pull/11715#issuecomment-903142961
> @hapihu You can do it in this PR if you prefer.
Ok, I'll finish it as soon as possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hapihu edited a comment on pull request #11715: [ISSUE 11714][DOC][spelling mistakes]fix spelling mistakes for doc
Posted by GitBox <gi...@apache.org>.
hapihu edited a comment on pull request #11715:
URL: https://github.com/apache/pulsar/pull/11715#issuecomment-903396093
Hello, @Anonymitaet
I have update all affected versions.
Would you like to review it for me again.
Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hapihu commented on pull request #11715: [ISSUE 11714][DOC][spelling mistakes]fix spelling mistakes for doc
Posted by GitBox <gi...@apache.org>.
hapihu commented on pull request #11715:
URL: https://github.com/apache/pulsar/pull/11715#issuecomment-902447828
> Thanks for your contribution. Does this affect only master or other versioned docs?
> If latter, could you please help update all affected versions? Thanks
Hi, @Anonymitaet
Other versions of the document also have these problems.
I ’d like to update all of the affected versions, such as branch-2.8,brabch-2.7, and so on.
Is it ok to handle only all Active branches?
Do I need to create a pull request for each affected version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11715: [ISSUE 11714][DOC][spelling mistakes]fix spelling mistakes for doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11715:
URL: https://github.com/apache/pulsar/pull/11715#issuecomment-903358397
@hapihu please update versioned docs [here](https://github.com/apache/pulsar/tree/master/site2/website/versioned_docs) in this PR, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hapihu commented on pull request #11715: [ISSUE 11714][DOC][spelling mistakes]fix spelling mistakes for doc
Posted by GitBox <gi...@apache.org>.
hapihu commented on pull request #11715:
URL: https://github.com/apache/pulsar/pull/11715#issuecomment-903396093
@Anonymitaet
I have update all affected versions.
Would you like to review it for me again.
Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #11715: [ISSUE 11714][DOC][spelling mistakes]fix spelling mistakes for doc
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #11715:
URL: https://github.com/apache/pulsar/pull/11715#issuecomment-903022028
@hapihu You can do it in this PR if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11715: [ISSUE 11714][DOC][spelling mistakes]fix spelling mistakes for doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #11715:
URL: https://github.com/apache/pulsar/pull/11715#discussion_r692623958
##########
File path: site2/docs/reference-configuration.md
##########
@@ -56,7 +56,7 @@ BookKeeper is a replicated log storage system that Pulsar uses for durable stora
|compactionRate|The rate at which compaction will read entries, in adds per second.|1000|
|isThrottleByBytes|Throttle compaction by bytes or by entries.|false|
|compactionRateByEntries|The rate at which compaction will read entries, in adds per second.|1000|
-|compactionRateByBytes|Set the rate at which compaction will readd entries. The unit is bytes added per second.|1000000|
+|compactionRateByBytes|Set the rate at which compaction will read entries. The unit is bytes added per second.|1000000|
Review comment:
```suggestion
|compactionRateByBytes|Set the rate at which compaction reads entries. The unit is bytes added per second.|1000000|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hapihu commented on pull request #11715: [ISSUE 11714][DOC][spelling mistakes]fix spelling mistakes for doc
Posted by GitBox <gi...@apache.org>.
hapihu commented on pull request #11715:
URL: https://github.com/apache/pulsar/pull/11715#issuecomment-903379080
> @hapihu please update versioned docs [here](https://github.com/apache/pulsar/tree/master/site2/website/versioned_docs) in this PR, thanks
Ok, sorry, I just found the file location of other version, I will fix it as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #11715: [ISSUE 11714][DOC][spelling mistakes]fix spelling mistakes for doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #11715:
URL: https://github.com/apache/pulsar/pull/11715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org