[jira] [Created] (CASSANDRA-18239) Remove eclipse warnings task

["Jacek Lewandowski (Jira)" <ji...@apache.org>]

Jacek Lewandowski created CASSANDRA-18239:
---------------------------------------------

             Summary: Remove eclipse warnings task
                 Key: CASSANDRA-18239
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
             Project: Cassandra
          Issue Type: Task
          Components: Build
            Reporter: Jacek Lewandowski


Eclipse warnings is used for static code analysis. However, it does not fit well into Cassandra code and practically we end up explicitly adding suppressions in many places just to satisfy that tool rather than fix the real issues.

This is an incomplete list of reasons to remove it:
- not closed resources are detected incorrectly
- does not recognize custom utility methods used to close the resources, which use use heavily in the code, like {{Throwables.close}}, {{FileUtils.close}}, {{closeQuietly}}...
- because of the above, we cannot make important things like {{Ref}} to implement {{Closeable}} as it would make the tool to explode with tons of warnings
- it complains about correct generics - something like "method X is not applicable for ..." when the code compiles successfully is not acceptable
- it is old and not maintained

There are better tools like IntelliJ inspections for example, which can also be run in headless mode




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org