You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/02 12:22:12 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #11890: fix(reports): expect more exceptions and fix validator config
dpgaspar opened a new pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (9d8950b) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a7bba92469025a1f75149ff616af9dba24e81717?el=desc) (a7bba92) will **decrease** coverage by `10.30%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
===========================================
- Coverage 64.45% 54.15% -10.31%
===========================================
Files 937 431 -506
Lines 45319 15194 -30125
Branches 4317 3885 -432
===========================================
- Hits 29211 8228 -20983
+ Misses 15948 6966 -8982
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.15% <ø> (+26.27%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | `14.28% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | `14.70% <0.00%> (-82.97%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `5.71% <0.00%> (-82.10%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `4.70% <0.00%> (-81.35%)` | :arrow_down: |
| ... and [831 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [a7bba92...9d8950b](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#discussion_r539254904
##########
File path: superset/reports/commands/execute.py
##########
@@ -192,45 +200,173 @@ def _send(self, report_schedule: ReportSchedule) -> None:
if notification_errors:
raise ReportScheduleNotificationError(";".join(notification_errors))
+ def is_in_grace_period(self) -> bool:
+ """
+ Checks if an alert is on it's grace period
+ """
+ last_success = ReportScheduleDAO.find_last_success_log(
+ self._report_schedule, session=self._session
+ )
+ return (
+ last_success is not None
+ and self._report_schedule.grace_period
+ and datetime.utcnow()
+ - timedelta(seconds=self._report_schedule.grace_period)
+ < last_success.end_dttm
+ )
+
+ def is_working_timeout(self) -> bool:
+ """
+ Checks if an alert is on a working timeout
+ """
+ return (
+ self._report_schedule.working_timeout is not None
+ and self._report_schedule.last_eval_dttm is not None
+ and datetime.utcnow()
+ - timedelta(seconds=self._report_schedule.working_timeout)
+ > self._report_schedule.last_eval_dttm
+ )
+
+ def next(self) -> None:
+ raise NotImplementedError()
+
+
+class ReportNotTriggeredErrorState(BaseReportState):
+ """
+ Handle Not triggered and Error state
+ next final states:
+ - Not Triggered
+ - Success
+ - Error
+ """
+
+ current_states = [ReportState.NOOP, ReportState.ERROR]
+ initial = True
+
+ def next(self) -> None:
+ self.set_state_and_log(ReportState.WORKING)
+ try:
+ # If it's an alert check if the alert is triggered
+ if self._report_schedule.type == ReportScheduleType.ALERT:
+ if not AlertCommand(self._report_schedule).run():
+ self.set_state_and_log(ReportState.NOOP)
+ return
+ self._send()
+ self.set_state_and_log(ReportState.SUCCESS)
+ except CommandException as ex:
+ self.set_state_and_log(ReportState.ERROR, error_message=str(ex))
+ raise ex
+
+
+class ReportWorkingState(BaseReportState):
+ """
+ Handle Working state
+ next states:
+ - Error
+ - Working
+ """
+
+ current_states = [ReportState.WORKING]
+
+ def next(self) -> None:
+ if self.is_working_timeout():
+ exception_timeout = ReportScheduleWorkingTimeoutError()
+ self.set_state_and_log(
+ ReportState.ERROR, error_message=str(exception_timeout),
+ )
+ raise exception_timeout
+ exception_working = ReportSchedulePreviousWorkingError()
+ self.set_state_and_log(
+ ReportState.WORKING, error_message=str(exception_working),
+ )
+ raise exception_working
+
+
+class ReportSuccessState(BaseReportState):
+ """
+ Handle Success, Grace state
+ next states:
+ - Grace
+ - Not triggered
+ - Success
+ """
+
+ current_states = [ReportState.SUCCESS, ReportState.GRACE]
+
+ def next(self) -> None:
+ self.set_state_and_log(ReportState.WORKING)
+ if self._report_schedule.type == ReportScheduleType.ALERT:
+ if self.is_in_grace_period():
+ self.set_state_and_log(
+ ReportState.GRACE,
+ error_message=str(ReportScheduleAlertGracePeriodError()),
+ )
+ return
+ self.set_state_and_log(
+ ReportState.NOOP,
+ error_message=str(ReportScheduleAlertEndGracePeriodError()),
+ )
+ return
+ try:
+ self._send()
+ self.set_state_and_log(ReportState.SUCCESS)
+ except CommandException as ex:
+ self.set_state_and_log(ReportState.ERROR, error_message=str(ex))
+
+
+class ReportScheduleStateMachine: # pylint: disable=too-few-public-methods
+ """
+ Simple state machine for Alerts/Reports states
+ """
+
+ states_cls = [ReportWorkingState, ReportNotTriggeredErrorState, ReportSuccessState]
+
+ def __init__(
+ self,
+ session: Session,
+ report_schedule: ReportSchedule,
+ scheduled_dttm: datetime,
+ ):
+ self._session = session
+ self._report_schedule = report_schedule
+ self._scheduled_dttm = scheduled_dttm
+
+ def run(self) -> None:
Review comment:
good point, yet it would be very unexpected. Addressed it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11890: fix(reports): expect more exceptions and fix validator config
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (4973f97) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `13.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
===========================================
- Coverage 67.65% 54.39% -13.26%
===========================================
Files 927 420 -507
Lines 45009 14790 -30219
Branches 4306 3809 -497
===========================================
- Hits 30450 8045 -22405
+ Misses 14455 6745 -7710
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.39% <ø> (-0.60%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | `14.28% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | `14.70% <0.00%> (-82.97%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `5.71% <0.00%> (-82.10%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `4.70% <0.00%> (-81.35%)` | :arrow_down: |
| ... and [767 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...4973f97](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (9d8950b) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a7bba92469025a1f75149ff616af9dba24e81717?el=desc) (a7bba92) will **decrease** coverage by `9.73%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 64.45% 54.72% -9.74%
==========================================
Files 937 431 -506
Lines 45319 15194 -30125
Branches 4317 3885 -432
==========================================
- Hits 29211 8315 -20896
+ Misses 15948 6879 -9069
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.72% <ø> (+26.84%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | `14.28% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | `14.70% <0.00%> (-82.97%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `5.71% <0.00%> (-82.10%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `4.70% <0.00%> (-81.35%)` | :arrow_down: |
| ... and [832 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [a7bba92...9d8950b](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (4cdeb66) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `12.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
===========================================
- Coverage 67.65% 55.10% -12.56%
===========================================
Files 927 425 -502
Lines 45009 14871 -30138
Branches 4306 3825 -481
===========================================
- Hits 30450 8194 -22256
+ Misses 14455 6677 -7778
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.10% <ø> (+0.11%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | `14.28% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | `14.70% <0.00%> (-82.97%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `5.71% <0.00%> (-82.10%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `4.70% <0.00%> (-81.35%)` | :arrow_down: |
| ... and [776 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...5fecbcf](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (a31ed5c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **increase** coverage by `5.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
+ Coverage 67.65% 73.57% +5.91%
==========================================
Files 927 468 -459
Lines 45009 16686 -28323
Branches 4306 4333 +27
==========================================
- Hits 30450 12276 -18174
+ Misses 14455 4307 -10148
+ Partials 104 103 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.86% <ø> (-0.13%)` | :arrow_down: |
| javascript | `63.16% <ø> (-0.02%)` | :arrow_down: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/messageToasts/components/Toast.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdC50c3g=) | `91.66% <0.00%> (-8.34%)` | :arrow_down: |
| [...perset-frontend/src/messageToasts/actions/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvYWN0aW9ucy9pbmRleC50cw==) | `88.46% <0.00%> (-7.70%)` | :arrow_down: |
| [...rc/explore/components/controls/TextAreaControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0QXJlYUNvbnRyb2wuanN4) | `83.33% <0.00%> (-1.86%)` | :arrow_down: |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `81.81% <0.00%> (-1.82%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdHlwZXMudHM=) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/utils/downloadAsImage.ts](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Rvd25sb2FkQXNJbWFnZS50cw==) | `33.33% <0.00%> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <0.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `73.59% <0.00%> (ø)` | |
| [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <0.00%> (ø)` | |
| [...t-frontend/src/views/CRUD/data/query/QueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeUxpc3QudHN4) | `72.11% <0.00%> (ø)` | |
| ... and [464 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...9e819e9](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (9e8c093) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `4.06%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.58% -4.07%
==========================================
Files 927 466 -461
Lines 45009 28602 -16407
Branches 4306 0 -4306
==========================================
- Hits 30450 18187 -12263
+ Misses 14455 10415 -4040
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.58% <82.97%> (-0.57%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [506 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...9e8c093](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (9e8c093) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **increase** coverage by `0.07%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
+ Coverage 67.65% 67.72% +0.07%
==========================================
Files 927 938 +11
Lines 45009 45399 +390
Branches 4306 4341 +35
==========================================
+ Hits 30450 30748 +298
- Misses 14455 14548 +93
+ Partials 104 103 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.10% <ø> (+0.11%)` | :arrow_up: |
| javascript | `62.99% <ø> (-0.18%)` | :arrow_down: |
| python | `64.21% <82.97%> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [67 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...9e8c093](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (5fecbcf) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `6.76%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 60.88% -6.77%
==========================================
Files 927 891 -36
Lines 45009 43488 -1521
Branches 4306 3825 -481
==========================================
- Hits 30450 26477 -3973
- Misses 14455 17011 +2556
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.10% <ø> (+0.11%)` | :arrow_up: |
| javascript | `?` | |
| python | `63.88% <82.97%> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [373 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...eca8c09](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (9bb4a95) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `4.38%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.26% -4.39%
==========================================
Files 927 466 -461
Lines 45009 28603 -16406
Branches 4306 0 -4306
==========================================
- Hits 30450 18096 -12354
+ Misses 14455 10507 -3948
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.26% <82.97%> (-0.89%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [516 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...9bb4a95](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (a31ed5c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `4.49%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.16% -4.50%
==========================================
Files 927 468 -459
Lines 45009 16678 -28331
Branches 4306 4333 +27
==========================================
- Hits 30450 10534 -19916
+ Misses 14455 5967 -8488
- Partials 104 177 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.16% <ø> (-0.02%)` | :arrow_down: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [631 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...9e819e9](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (9e8c093) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `4.01%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.63% -4.02%
==========================================
Files 927 466 -461
Lines 45009 28617 -16392
Branches 4306 0 -4306
==========================================
- Hits 30450 18210 -12240
+ Misses 14455 10407 -4048
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.63% <82.97%> (-0.52%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [499 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...9e8c093](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): expect more exceptions and fix validator config
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (a525384) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `4.49%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.15% -4.50%
==========================================
Files 927 468 -459
Lines 45009 16676 -28333
Branches 4306 4331 +25
==========================================
- Hits 30450 10532 -19918
+ Misses 14455 5967 -8488
- Partials 104 177 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.15% <ø> (-0.02%)` | :arrow_down: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [631 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...573bc93](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (5fecbcf) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `4.23%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.41% -4.24%
==========================================
Files 927 466 -461
Lines 45009 28615 -16394
Branches 4306 0 -4306
==========================================
- Hits 30450 18147 -12303
+ Misses 14455 10468 -3987
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.41% <82.97%> (-0.74%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [511 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...5fecbcf](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (eca8c09) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `4.38%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.26% -4.39%
==========================================
Files 927 466 -461
Lines 45009 28602 -16407
Branches 4306 0 -4306
==========================================
- Hits 30450 18095 -12355
+ Misses 14455 10507 -3948
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.26% <82.97%> (-0.89%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [517 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...eca8c09](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (0340edd) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a7bba92469025a1f75149ff616af9dba24e81717?el=desc) (a7bba92) will **decrease** coverage by `9.92%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 64.45% 54.52% -9.93%
==========================================
Files 937 431 -506
Lines 45319 15194 -30125
Branches 4317 3885 -432
==========================================
- Hits 29211 8285 -20926
+ Misses 15948 6909 -9039
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.52% <ø> (+26.64%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | `14.28% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | `14.70% <0.00%> (-82.97%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `5.71% <0.00%> (-82.10%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `4.70% <0.00%> (-81.35%)` | :arrow_down: |
| ... and [832 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [a7bba92...289425d](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (9e8c093) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `0.04%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 67.60% -0.05%
==========================================
Files 927 938 +11
Lines 45009 45399 +390
Branches 4306 4341 +35
==========================================
+ Hits 30450 30692 +242
- Misses 14455 14600 +145
- Partials 104 107 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.51% <ø> (-0.48%)` | :arrow_down: |
| javascript | `62.99% <ø> (-0.18%)` | :arrow_down: |
| python | `64.21% <82.97%> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [75 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...9e8c093](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (289425d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a7bba92469025a1f75149ff616af9dba24e81717?el=desc) (a7bba92) will **decrease** coverage by `10.57%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
===========================================
- Coverage 64.45% 53.88% -10.58%
===========================================
Files 937 431 -506
Lines 45319 15194 -30125
Branches 4317 3885 -432
===========================================
- Hits 29211 8187 -21024
+ Misses 15948 7007 -8941
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.88% <ø> (+26.00%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | `14.28% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | `14.70% <0.00%> (-82.97%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `5.71% <0.00%> (-82.10%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `4.70% <0.00%> (-81.35%)` | :arrow_down: |
| ... and [830 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [a7bba92...289425d](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#discussion_r536032049
##########
File path: superset/models/reports.py
##########
@@ -122,7 +123,10 @@ class ReportSchedule(Model, AuditMixinNullable):
# Log retention
log_retention = Column(Integer, default=90)
+ # (Alerts) After a success how long to wait for a new trigger (seconds)
grace_period = Column(Integer, default=60 * 60 * 4)
+ # (Alerts/Reports) Unlock a possible stalled working state
+ working_timeout = Column(Integer, default=60 * 60 * 1)
Review comment:
Should defaults be defined in the application rather than in the metadata? It feels clearer if we leave defaults as `null` to make it possible to change defaults later.
##########
File path: superset/reports/commands/alert.py
##########
@@ -70,7 +76,7 @@ def _validate_operator(self, rows: np.recarray) -> None:
raise AlertQueryMultipleColumnsError(
_(
"Alert query returned more then one column. %s columns returned"
- % len(rows[0])
+ % (len(rows[0]) - 1)
Review comment:
A comment here could be helpful (I assume this is the case where the first column in the index).
##########
File path: superset/reports/commands/execute.py
##########
@@ -192,45 +201,177 @@ def _send(self, report_schedule: ReportSchedule) -> None:
if notification_errors:
raise ReportScheduleNotificationError(";".join(notification_errors))
+ def is_in_grace_period(self) -> bool:
+ """
+ Checks if an alert is on it's grace period
+ """
+ last_success = ReportScheduleDAO.find_last_success_log(
+ self._report_schedule, session=self._session
+ )
+ return (
+ last_success is not None
+ and self._report_schedule.grace_period
+ and datetime.utcnow()
+ - timedelta(seconds=self._report_schedule.grace_period)
+ < last_success.end_dttm
+ )
+
+ def is_working_timeout(self) -> bool:
Review comment:
Should this be called `is_on_working_timeout` just to make it clear that it has exceeded the threshold? To someone with less knowledge `is_working_timeout` might imply that a timeout is working.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (5fecbcf) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `3.76%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.88% -3.77%
==========================================
Files 927 466 -461
Lines 45009 28617 -16392
Branches 4306 0 -4306
==========================================
- Hits 30450 18282 -12168
+ Misses 14455 10335 -4120
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.88% <82.97%> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [505 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...5fecbcf](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (5fa090a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `4.29%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.35% -4.30%
==========================================
Files 927 466 -461
Lines 45009 28615 -16394
Branches 4306 0 -4306
==========================================
- Hits 30450 18129 -12321
+ Misses 14455 10486 -3969
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.35% <82.97%> (-0.80%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [509 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...5fa090a](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (9e8c093) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `4.38%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.26% -4.39%
==========================================
Files 927 466 -461
Lines 45009 28602 -16407
Branches 4306 0 -4306
==========================================
- Hits 30450 18095 -12355
+ Misses 14455 10507 -3948
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.26% <82.97%> (-0.89%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [517 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...9e8c093](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (eca8c09) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **increase** coverage by `0.04%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
+ Coverage 67.65% 67.69% +0.04%
==========================================
Files 927 938 +11
Lines 45009 45399 +390
Branches 4306 4341 +35
==========================================
+ Hits 30450 30735 +285
- Misses 14455 14561 +106
+ Partials 104 103 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.10% <ø> (+0.11%)` | :arrow_up: |
| javascript | `62.99% <ø> (-0.18%)` | :arrow_down: |
| python | `64.16% <82.97%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [67 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...eca8c09](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (9e8c093) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `4.25%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.39% -4.26%
==========================================
Files 927 938 +11
Lines 45009 45390 +381
Branches 4306 4341 +35
==========================================
- Hits 30450 28776 -1674
- Misses 14455 16437 +1982
- Partials 104 177 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.99% <ø> (-0.18%)` | :arrow_down: |
| python | `63.63% <82.97%> (-0.52%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [230 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...9e8c093](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (0340edd) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a7bba92469025a1f75149ff616af9dba24e81717?el=desc) (a7bba92) will **decrease** coverage by `10.50%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
===========================================
- Coverage 64.45% 53.95% -10.51%
===========================================
Files 937 431 -506
Lines 45319 15194 -30125
Branches 4317 3885 -432
===========================================
- Hits 29211 8198 -21013
+ Misses 15948 6996 -8952
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.95% <ø> (+26.07%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | `14.28% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | `14.70% <0.00%> (-82.97%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `5.71% <0.00%> (-82.10%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `4.70% <0.00%> (-81.35%)` | :arrow_down: |
| ... and [831 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [a7bba92...289425d](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#discussion_r539498483
##########
File path: superset/reports/commands/alert.py
##########
@@ -70,7 +76,7 @@ def _validate_operator(self, rows: np.recarray) -> None:
raise AlertQueryMultipleColumnsError(
_(
"Alert query returned more then one column. %s columns returned"
- % len(rows[0])
+ % (len(rows[0]) - 1)
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (9bb4a95) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `3.72%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.93% -3.73%
==========================================
Files 927 466 -461
Lines 45009 28603 -16406
Branches 4306 0 -4306
==========================================
- Hits 30450 18286 -12164
+ Misses 14455 10317 -4138
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.93% <82.97%> (-0.23%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [507 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...9bb4a95](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (eca8c09) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `0.07%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 67.57% -0.08%
==========================================
Files 927 938 +11
Lines 45009 45399 +390
Branches 4306 4341 +35
==========================================
+ Hits 30450 30679 +229
- Misses 14455 14613 +158
- Partials 104 107 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.52% <ø> (-0.47%)` | :arrow_down: |
| javascript | `62.99% <ø> (-0.18%)` | :arrow_down: |
| python | `64.16% <82.97%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [75 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...eca8c09](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (9bb4a95) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `3.56%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 64.08% -3.57%
==========================================
Files 927 466 -461
Lines 45009 28618 -16391
Branches 4306 0 -4306
==========================================
- Hits 30450 18340 -12110
+ Misses 14455 10278 -4177
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.08% <82.97%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [499 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...9bb4a95](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (eca8c09) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `4.29%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.36% -4.30%
==========================================
Files 927 938 +11
Lines 45009 45390 +381
Branches 4306 4341 +35
==========================================
- Hits 30450 28760 -1690
- Misses 14455 16453 +1998
- Partials 104 177 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.99% <ø> (-0.18%)` | :arrow_down: |
| python | `63.57% <82.97%> (-0.58%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [231 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...eca8c09](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (5fa090a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `6.76%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 60.88% -6.77%
==========================================
Files 927 891 -36
Lines 45009 43488 -1521
Branches 4306 3825 -481
==========================================
- Hits 30450 26477 -3973
- Misses 14455 17011 +2556
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.10% <ø> (+0.11%)` | :arrow_up: |
| javascript | `?` | |
| python | `63.88% <82.97%> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [374 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...5fa090a](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): expect more exceptions and fix validator config
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (ad3f7f8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `4.47%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.18% -4.48%
==========================================
Files 927 466 -461
Lines 45009 16627 -28382
Branches 4306 4309 +3
==========================================
- Hits 30450 10505 -19945
+ Misses 14455 5945 -8510
- Partials 104 177 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.18% <ø> (+<0.01%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [623 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...ad3f7f8](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (5fa090a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `6.96%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 60.68% -6.97%
==========================================
Files 927 891 -36
Lines 45009 43488 -1521
Branches 4306 3825 -481
==========================================
- Hits 30450 26390 -4060
- Misses 14455 17098 +2643
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.52% <ø> (-0.47%)` | :arrow_down: |
| javascript | `?` | |
| python | `63.88% <82.97%> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [374 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...5fa090a](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (9e8c093) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `4.11%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.54% -4.12%
==========================================
Files 927 938 +11
Lines 45009 45390 +381
Branches 4306 4341 +35
==========================================
- Hits 30450 28842 -1608
- Misses 14455 16371 +1916
- Partials 104 177 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.99% <ø> (-0.18%)` | :arrow_down: |
| python | `63.86% <82.97%> (-0.29%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [227 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...9e8c093](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (eca8c09) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `4.07%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.57% -4.08%
==========================================
Files 927 466 -461
Lines 45009 28617 -16392
Branches 4306 0 -4306
==========================================
- Hits 30450 18194 -12256
+ Misses 14455 10423 -4032
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.57% <82.97%> (-0.58%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [500 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...eca8c09](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (5fecbcf) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `3.77%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.88% -3.78%
==========================================
Files 927 466 -461
Lines 45009 28615 -16394
Branches 4306 0 -4306
==========================================
- Hits 30450 18280 -12170
+ Misses 14455 10335 -4120
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.88% <82.97%> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [507 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...5fecbcf](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#discussion_r539254904
##########
File path: superset/reports/commands/execute.py
##########
@@ -192,45 +200,173 @@ def _send(self, report_schedule: ReportSchedule) -> None:
if notification_errors:
raise ReportScheduleNotificationError(";".join(notification_errors))
+ def is_in_grace_period(self) -> bool:
+ """
+ Checks if an alert is on it's grace period
+ """
+ last_success = ReportScheduleDAO.find_last_success_log(
+ self._report_schedule, session=self._session
+ )
+ return (
+ last_success is not None
+ and self._report_schedule.grace_period
+ and datetime.utcnow()
+ - timedelta(seconds=self._report_schedule.grace_period)
+ < last_success.end_dttm
+ )
+
+ def is_working_timeout(self) -> bool:
+ """
+ Checks if an alert is on a working timeout
+ """
+ return (
+ self._report_schedule.working_timeout is not None
+ and self._report_schedule.last_eval_dttm is not None
+ and datetime.utcnow()
+ - timedelta(seconds=self._report_schedule.working_timeout)
+ > self._report_schedule.last_eval_dttm
+ )
+
+ def next(self) -> None:
+ raise NotImplementedError()
+
+
+class ReportNotTriggeredErrorState(BaseReportState):
+ """
+ Handle Not triggered and Error state
+ next final states:
+ - Not Triggered
+ - Success
+ - Error
+ """
+
+ current_states = [ReportState.NOOP, ReportState.ERROR]
+ initial = True
+
+ def next(self) -> None:
+ self.set_state_and_log(ReportState.WORKING)
+ try:
+ # If it's an alert check if the alert is triggered
+ if self._report_schedule.type == ReportScheduleType.ALERT:
+ if not AlertCommand(self._report_schedule).run():
+ self.set_state_and_log(ReportState.NOOP)
+ return
+ self._send()
+ self.set_state_and_log(ReportState.SUCCESS)
+ except CommandException as ex:
+ self.set_state_and_log(ReportState.ERROR, error_message=str(ex))
+ raise ex
+
+
+class ReportWorkingState(BaseReportState):
+ """
+ Handle Working state
+ next states:
+ - Error
+ - Working
+ """
+
+ current_states = [ReportState.WORKING]
+
+ def next(self) -> None:
+ if self.is_working_timeout():
+ exception_timeout = ReportScheduleWorkingTimeoutError()
+ self.set_state_and_log(
+ ReportState.ERROR, error_message=str(exception_timeout),
+ )
+ raise exception_timeout
+ exception_working = ReportSchedulePreviousWorkingError()
+ self.set_state_and_log(
+ ReportState.WORKING, error_message=str(exception_working),
+ )
+ raise exception_working
+
+
+class ReportSuccessState(BaseReportState):
+ """
+ Handle Success, Grace state
+ next states:
+ - Grace
+ - Not triggered
+ - Success
+ """
+
+ current_states = [ReportState.SUCCESS, ReportState.GRACE]
+
+ def next(self) -> None:
+ self.set_state_and_log(ReportState.WORKING)
+ if self._report_schedule.type == ReportScheduleType.ALERT:
+ if self.is_in_grace_period():
+ self.set_state_and_log(
+ ReportState.GRACE,
+ error_message=str(ReportScheduleAlertGracePeriodError()),
+ )
+ return
+ self.set_state_and_log(
+ ReportState.NOOP,
+ error_message=str(ReportScheduleAlertEndGracePeriodError()),
+ )
+ return
+ try:
+ self._send()
+ self.set_state_and_log(ReportState.SUCCESS)
+ except CommandException as ex:
+ self.set_state_and_log(ReportState.ERROR, error_message=str(ex))
+
+
+class ReportScheduleStateMachine: # pylint: disable=too-few-public-methods
+ """
+ Simple state machine for Alerts/Reports states
+ """
+
+ states_cls = [ReportWorkingState, ReportNotTriggeredErrorState, ReportSuccessState]
+
+ def __init__(
+ self,
+ session: Session,
+ report_schedule: ReportSchedule,
+ scheduled_dttm: datetime,
+ ):
+ self._session = session
+ self._report_schedule = report_schedule
+ self._scheduled_dttm = scheduled_dttm
+
+ def run(self) -> None:
Review comment:
good point, it would be very unexpected but possible. Addressed it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (a31ed5c) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **increase** coverage by `5.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
+ Coverage 67.65% 73.23% +5.58%
==========================================
Files 927 468 -459
Lines 45009 16686 -28323
Branches 4306 4333 +27
==========================================
- Hits 30450 12220 -18230
+ Misses 14455 4359 -10096
- Partials 104 107 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.27% <ø> (-0.72%)` | :arrow_down: |
| javascript | `63.16% <ø> (-0.02%)` | :arrow_down: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...et-frontend/src/messageToasts/components/Toast.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdC50c3g=) | `91.66% <0.00%> (-8.34%)` | :arrow_down: |
| [...perset-frontend/src/messageToasts/actions/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvYWN0aW9ucy9pbmRleC50cw==) | `88.46% <0.00%> (-7.70%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.12% <0.00%> (-5.17%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.25% <0.00%> (-4.28%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `49.01% <0.00%> (-3.93%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.60% <0.00%> (-3.31%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `86.48% <0.00%> (-2.71%)` | :arrow_down: |
| [...rc/explore/components/controls/TextAreaControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0QXJlYUNvbnRyb2wuanN4) | `83.33% <0.00%> (-1.86%)` | :arrow_down: |
| ... and [474 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...9e819e9](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#discussion_r539537605
##########
File path: superset/models/reports.py
##########
@@ -122,7 +123,10 @@ class ReportSchedule(Model, AuditMixinNullable):
# Log retention
log_retention = Column(Integer, default=90)
+ # (Alerts) After a success how long to wait for a new trigger (seconds)
grace_period = Column(Integer, default=60 * 60 * 4)
+ # (Alerts/Reports) Unlock a possible stalled working state
+ working_timeout = Column(Integer, default=60 * 60 * 1)
Review comment:
this default is actually imposed by SQLAlchemy only, server_default would place it at the db level. I confess I did not knew that :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): expect more exceptions and fix validator config
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (573bc93) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `4.49%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.15% -4.50%
==========================================
Files 927 468 -459
Lines 45009 16676 -28333
Branches 4306 4331 +25
==========================================
- Hits 30450 10532 -19918
+ Misses 14455 5967 -8488
- Partials 104 177 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.15% <ø> (-0.02%)` | :arrow_down: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [631 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...4f1746d](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (eca8c09) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `4.02%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.63% -4.03%
==========================================
Files 927 938 +11
Lines 45009 45390 +381
Branches 4306 4341 +35
==========================================
- Hits 30450 28883 -1567
- Misses 14455 16330 +1875
- Partials 104 177 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.99% <ø> (-0.18%)` | :arrow_down: |
| python | `64.00% <82.97%> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [229 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...eca8c09](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#discussion_r539365321
##########
File path: superset/reports/commands/alert.py
##########
@@ -70,7 +76,7 @@ def _validate_operator(self, rows: np.recarray) -> None:
raise AlertQueryMultipleColumnsError(
_(
"Alert query returned more then one column. %s columns returned"
- % len(rows[0])
+ % (len(rows[0]) - 1)
Review comment:
Exactly that, I'll drop a comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): expect more exceptions and fix validator config
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (4973f97) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `12.67%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
===========================================
- Coverage 67.65% 54.98% -12.68%
===========================================
Files 927 420 -507
Lines 45009 14790 -30219
Branches 4306 3809 -497
===========================================
- Hits 30450 8132 -22318
+ Misses 14455 6658 -7797
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.98% <ø> (-0.01%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | `14.28% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | `14.70% <0.00%> (-82.97%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `5.71% <0.00%> (-82.10%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `4.70% <0.00%> (-81.35%)` | :arrow_down: |
| ... and [766 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...4973f97](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on a change in pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#discussion_r538829281
##########
File path: superset/reports/commands/execute.py
##########
@@ -192,45 +200,173 @@ def _send(self, report_schedule: ReportSchedule) -> None:
if notification_errors:
raise ReportScheduleNotificationError(";".join(notification_errors))
+ def is_in_grace_period(self) -> bool:
+ """
+ Checks if an alert is on it's grace period
+ """
+ last_success = ReportScheduleDAO.find_last_success_log(
+ self._report_schedule, session=self._session
+ )
+ return (
+ last_success is not None
+ and self._report_schedule.grace_period
+ and datetime.utcnow()
+ - timedelta(seconds=self._report_schedule.grace_period)
+ < last_success.end_dttm
+ )
+
+ def is_working_timeout(self) -> bool:
+ """
+ Checks if an alert is on a working timeout
+ """
+ return (
+ self._report_schedule.working_timeout is not None
+ and self._report_schedule.last_eval_dttm is not None
+ and datetime.utcnow()
+ - timedelta(seconds=self._report_schedule.working_timeout)
+ > self._report_schedule.last_eval_dttm
+ )
+
+ def next(self) -> None:
+ raise NotImplementedError()
+
+
+class ReportNotTriggeredErrorState(BaseReportState):
+ """
+ Handle Not triggered and Error state
+ next final states:
+ - Not Triggered
+ - Success
+ - Error
+ """
+
+ current_states = [ReportState.NOOP, ReportState.ERROR]
+ initial = True
+
+ def next(self) -> None:
+ self.set_state_and_log(ReportState.WORKING)
+ try:
+ # If it's an alert check if the alert is triggered
+ if self._report_schedule.type == ReportScheduleType.ALERT:
+ if not AlertCommand(self._report_schedule).run():
+ self.set_state_and_log(ReportState.NOOP)
+ return
+ self._send()
+ self.set_state_and_log(ReportState.SUCCESS)
+ except CommandException as ex:
+ self.set_state_and_log(ReportState.ERROR, error_message=str(ex))
+ raise ex
+
+
+class ReportWorkingState(BaseReportState):
+ """
+ Handle Working state
+ next states:
+ - Error
+ - Working
+ """
+
+ current_states = [ReportState.WORKING]
+
+ def next(self) -> None:
+ if self.is_working_timeout():
+ exception_timeout = ReportScheduleWorkingTimeoutError()
+ self.set_state_and_log(
+ ReportState.ERROR, error_message=str(exception_timeout),
+ )
+ raise exception_timeout
+ exception_working = ReportSchedulePreviousWorkingError()
+ self.set_state_and_log(
+ ReportState.WORKING, error_message=str(exception_working),
+ )
+ raise exception_working
+
+
+class ReportSuccessState(BaseReportState):
+ """
+ Handle Success, Grace state
+ next states:
+ - Grace
+ - Not triggered
+ - Success
+ """
+
+ current_states = [ReportState.SUCCESS, ReportState.GRACE]
+
+ def next(self) -> None:
+ self.set_state_and_log(ReportState.WORKING)
+ if self._report_schedule.type == ReportScheduleType.ALERT:
+ if self.is_in_grace_period():
+ self.set_state_and_log(
+ ReportState.GRACE,
+ error_message=str(ReportScheduleAlertGracePeriodError()),
+ )
+ return
+ self.set_state_and_log(
+ ReportState.NOOP,
+ error_message=str(ReportScheduleAlertEndGracePeriodError()),
+ )
+ return
+ try:
+ self._send()
+ self.set_state_and_log(ReportState.SUCCESS)
+ except CommandException as ex:
+ self.set_state_and_log(ReportState.ERROR, error_message=str(ex))
+
+
+class ReportScheduleStateMachine: # pylint: disable=too-few-public-methods
+ """
+ Simple state machine for Alerts/Reports states
+ """
+
+ states_cls = [ReportWorkingState, ReportNotTriggeredErrorState, ReportSuccessState]
+
+ def __init__(
+ self,
+ session: Session,
+ report_schedule: ReportSchedule,
+ scheduled_dttm: datetime,
+ ):
+ self._session = session
+ self._report_schedule = report_schedule
+ self._scheduled_dttm = scheduled_dttm
+
+ def run(self) -> None:
Review comment:
It looks like this will silently swallow not-found states?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (289425d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a7bba92469025a1f75149ff616af9dba24e81717?el=desc) (a7bba92) will **decrease** coverage by `10.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
===========================================
- Coverage 64.45% 54.45% -10.01%
===========================================
Files 937 431 -506
Lines 45319 15194 -30125
Branches 4317 3885 -432
===========================================
- Hits 29211 8274 -20937
+ Misses 15948 6920 -9028
+ Partials 160 0 -160
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.45% <ø> (+26.57%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | `14.28% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | `14.70% <0.00%> (-82.97%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `5.71% <0.00%> (-82.10%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `4.70% <0.00%> (-81.35%)` | :arrow_down: |
| ... and [831 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [a7bba92...289425d](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (5fecbcf) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `6.96%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 60.68% -6.97%
==========================================
Files 927 891 -36
Lines 45009 43488 -1521
Branches 4306 3825 -481
==========================================
- Hits 30450 26390 -4060
- Misses 14455 17098 +2643
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.52% <ø> (-0.47%)` | :arrow_down: |
| javascript | `?` | |
| python | `63.88% <82.97%> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [373 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...eca8c09](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (ad97aac) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `0.08%`.
> The diff coverage is `62.26%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 67.56% -0.09%
==========================================
Files 927 938 +11
Lines 45009 45399 +390
Branches 4306 4341 +35
==========================================
+ Hits 30450 30675 +225
- Misses 14455 14617 +162
- Partials 104 107 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.51% <44.82%> (-0.48%)` | :arrow_down: |
| javascript | `62.99% <32.73%> (-0.18%)` | :arrow_down: |
| python | `64.15% <67.73%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `50.58% <0.00%> (-3.08%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `86.11% <ø> (-3.08%)` | :arrow_down: |
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `58.18% <ø> (ø)` | |
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...-frontend/src/components/Button/Button.stories.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL0J1dHRvbi5zdG9yaWVzLmpzeA==) | `82.35% <ø> (ø)` | |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `52.17% <0.00%> (+14.07%)` | :arrow_up: |
| [superset-frontend/src/utils/downloadAsImage.ts](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Rvd25sb2FkQXNJbWFnZS50cw==) | `33.33% <0.00%> (ø)` | |
| [...t-frontend/src/views/CRUD/data/query/QueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeUxpc3QudHN4) | `72.11% <ø> (ø)` | |
| [...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9TYXZlZFF1ZXJpZXMudHN4) | `62.24% <0.00%> (ø)` | |
| ... and [93 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...5fecbcf](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (5fa090a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `3.76%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.88% -3.77%
==========================================
Files 927 466 -461
Lines 45009 28617 -16392
Branches 4306 0 -4306
==========================================
- Hits 30450 18282 -12168
+ Misses 14455 10335 -4120
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.88% <82.97%> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [505 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...5fa090a](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11890: fix(reports): validator_config, report state machine, working_timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11890:
URL: https://github.com/apache/incubator-superset/pull/11890#issuecomment-737215126
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=h1) Report
> Merging [#11890](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=desc) (eca8c09) into [master](https://codecov.io/gh/apache/incubator-superset/commit/07288789e2adce50939eeb564b1771120bfbc11d?el=desc) (0728878) will **decrease** coverage by `4.02%`.
> The diff coverage is `82.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11890 +/- ##
==========================================
- Coverage 67.65% 63.63% -4.03%
==========================================
Files 927 938 +11
Lines 45009 45390 +381
Branches 4306 4341 +35
==========================================
- Hits 30450 28882 -1568
- Misses 14455 16331 +1876
- Partials 104 177 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.99% <ø> (-0.18%)` | :arrow_down: |
| python | `64.00% <82.97%> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.94% <91.58%> (-3.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.41% <100.00%> (+0.29%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.41% <100.00%> (ø)` | |
| ... and [230 more](https://codecov.io/gh/apache/incubator-superset/pull/11890/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=footer). Last update [0728878...eca8c09](https://codecov.io/gh/apache/incubator-superset/pull/11890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org