[GitHub] [airflow] ecerulm commented on a change in pull request #13073: Script to generate integrations.json

[GitBox <gi...@apache.org>]

ecerulm commented on a change in pull request #13073:
URL: https://github.com/apache/airflow/pull/13073#discussion_r543175130



##########
File path: airflow/providers/microsoft/azure/provider.yaml
##########
@@ -30,21 +30,26 @@ integrations:
     tags: [azure]
   - integration-name: Microsoft Azure Blob Storage
     external-doc-url: https://azure.microsoft.com/en-us/services/storage/blobs/
+    logo: /integration-logos/azure/Blob Storage.svg
     tags: [azure]
   - integration-name: Microsoft Azure Container Instances
     external-doc-url: https://azure.microsoft.com/en-us/services/container-instances/
+    logo: /integration-logos/azure/Container Instances.svg
     tags: [azure]
   - integration-name: Microsoft Azure Cosmos DB
     external-doc-url: https://azure.microsoft.com/en-us/services/cosmos-db/
+    logo: /integration-logos/azure/Azure Cosmos DB.svg
     tags: [azure]
   - integration-name: Microsoft Azure Data Explorer
     external-doc-url: https://azure.microsoft.com/en-us/services/data-explorer/
     tags: [azure]
   - integration-name: Microsoft Azure Data Lake Storage
     external-doc-url: https://azure.microsoft.com/en-us/services/storage/data-lake-storage/
+    logo: /integration-logos/azure/Data Lake Storage.svg
     tags: [azure]
   - integration-name: Microsoft Azure Files
     external-doc-url: https://azure.microsoft.com/en-us/services/storage/files/
+    logo: /integration-logos/azure/Azure Files.svg

Review comment:
       Those files are today in the [`airflow-site` repo at landing-pages/site/static/integration-logos](https://github.com/apache/airflow-site/tree/master/landing-pages/site/static/integration-logos)
   
   I don't know if we can check that the files exist in **other repo** as a pre commit hook, I mean I can but it will fail in CI I guess because `airflow-site` won't be there at that time. 
   
   So do you want to copy the logos into this repo instead, and then let this script generate:
   
       ../airflow-site/landing-pages/site/data/integrations.json
       ../airflow-site/landing-pages/site/static/integrations.json
        ../airflow-site/landing-pages/site/static/integrations-logos/**
    




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org