You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/01/27 22:23:39 UTC
[kudu-CR](branch-1.18.x) [consensus] micro-optimisation on RequestVote()
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22402
Change subject: [consensus] micro-optimisation on RequestVote()
......................................................................
[consensus] micro-optimisation on RequestVote()
This patch simplifies the logic around 'update_guard' in
RaftConsensus::RequestVote() since unique_lock<>::try_lock() already
reports if the underlying locking primitive has been acquired. It also
fixes compilation warning issued by GCC13/14 about ignoring the return
value of the unique_lock<>::try_lock() method.
This patch doesn't contain any functional modifications.
Change-Id: I115d88b90ce6ec94737bb85f1003cf943e1ab9e0
Reviewed-on: http://gerrit.cloudera.org:8080/22387
Tested-by: Kudu Jenkins
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit 47af08154d1522ae4910ea306cf77c2b0e8e4f81)
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/22402/1
--
To view, visit http://gerrit.cloudera.org:8080/22402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I115d88b90ce6ec94737bb85f1003cf943e1ab9e0
Gerrit-Change-Number: 22402
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR](branch-1.18.x) [consensus] micro-optimisation on RequestVote()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22402 )
Change subject: [consensus] micro-optimisation on RequestVote()
......................................................................
Patch Set 1: Verified+1
unrelated failures in flaky tests
--
To view, visit http://gerrit.cloudera.org:8080/22402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I115d88b90ce6ec94737bb85f1003cf943e1ab9e0
Gerrit-Change-Number: 22402
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 29 Jan 2025 05:27:39 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [consensus] micro-optimisation on RequestVote()
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22402 )
Change subject: [consensus] micro-optimisation on RequestVote()
......................................................................
[consensus] micro-optimisation on RequestVote()
This patch simplifies the logic around 'update_guard' in
RaftConsensus::RequestVote() since unique_lock<>::try_lock() already
reports if the underlying locking primitive has been acquired. It also
fixes compilation warning issued by GCC13/14 about ignoring the return
value of the unique_lock<>::try_lock() method.
This patch doesn't contain any functional modifications.
Change-Id: I115d88b90ce6ec94737bb85f1003cf943e1ab9e0
Reviewed-on: http://gerrit.cloudera.org:8080/22387
Tested-by: Kudu Jenkins
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit 47af08154d1522ae4910ea306cf77c2b0e8e4f81)
Reviewed-on: http://gerrit.cloudera.org:8080/22402
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Gabriella Lotz <lo...@gmail.com>
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 8 insertions(+), 8 deletions(-)
Approvals:
Alexey Serbin: Verified
Gabriella Lotz: Looks good to me, but someone else must approve
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/22402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I115d88b90ce6ec94737bb85f1003cf943e1ab9e0
Gerrit-Change-Number: 22402
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.18.x) [consensus] micro-optimisation on RequestVote()
Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/22402 )
Change subject: [consensus] micro-optimisation on RequestVote()
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/22402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I115d88b90ce6ec94737bb85f1003cf943e1ab9e0
Gerrit-Change-Number: 22402
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 29 Jan 2025 08:50:10 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [consensus] micro-optimisation on RequestVote()
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22402 )
Change subject: [consensus] micro-optimisation on RequestVote()
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/967/
--
To view, visit http://gerrit.cloudera.org:8080/22402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I115d88b90ce6ec94737bb85f1003cf943e1ab9e0
Gerrit-Change-Number: 22402
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 27 Jan 2025 22:23:48 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [consensus] micro-optimisation on RequestVote()
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22402 )
Change subject: [consensus] micro-optimisation on RequestVote()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I115d88b90ce6ec94737bb85f1003cf943e1ab9e0
Gerrit-Change-Number: 22402
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 04 Feb 2025 23:00:27 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [consensus] micro-optimisation on RequestVote()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [consensus] micro-optimisation on RequestVote()
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/22402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I115d88b90ce6ec94737bb85f1003cf943e1ab9e0
Gerrit-Change-Number: 22402
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.18.x) [consensus] micro-optimisation on RequestVote()
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22402 )
Change subject: [consensus] micro-optimisation on RequestVote()
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/967/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I115d88b90ce6ec94737bb85f1003cf943e1ab9e0
Gerrit-Change-Number: 22402
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 27 Jan 2025 23:23:27 +0000
Gerrit-HasComments: No