You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by bf...@apache.org on 2013/12/13 19:39:45 UTC

git commit: updated refs/heads/master to 44f71f0

Updated Branches:
  refs/heads/master 8821d7544 -> 44f71f06e


CLOUDSTACK-5477: Fix view all link breaking detail view

Fixes issue where 'view all' link permanently writes properties to
cloudStack namespace, causing breakage when viewing detail view from
another location.


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/44f71f06
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/44f71f06
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/44f71f06

Branch: refs/heads/master
Commit: 44f71f06e26831a8e1b9e5d2973192dccaab99de
Parents: 8821d75
Author: Brian Federle <br...@citrix.com>
Authored: Fri Dec 13 10:34:49 2013 -0800
Committer: Brian Federle <br...@citrix.com>
Committed: Fri Dec 13 10:37:40 2013 -0800

----------------------------------------------------------------------
 ui/scripts/ui/widgets/detailView.js | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/44f71f06/ui/scripts/ui/widgets/detailView.js
----------------------------------------------------------------------
diff --git a/ui/scripts/ui/widgets/detailView.js b/ui/scripts/ui/widgets/detailView.js
index d991f2d..d29f32e 100644
--- a/ui/scripts/ui/widgets/detailView.js
+++ b/ui/scripts/ui/widgets/detailView.js
@@ -754,15 +754,16 @@
         viewAllPath = viewAllID.split('.');
 
         if (viewAllPath.length == 2) {
-            if (viewAllPath[0] != '_zone')
-                listViewArgs = cloudStackArgs.sections[viewAllPath[0]].sections[viewAllPath[1]];
-            else {
+            if (viewAllPath[0] != '_zone') {
+                listViewArgs = $.extend(true, {}, cloudStackArgs.sections[viewAllPath[0]].sections[viewAllPath[1]]);
+            } else {
                 // Sub-section of the zone chart
-                listViewArgs = cloudStackArgs.sections.system
-                    .subsections[viewAllPath[1]];
+                listViewArgs = $.extend(true, {}, cloudStackArgs.sections.system
+                    .subsections[viewAllPath[1]]);
             }
-        } else
-            listViewArgs = cloudStackArgs.sections[viewAllPath[0]];
+        } else {
+            listViewArgs = $.extend(true, {}, cloudStackArgs.sections[viewAllPath[0]]);
+        }
 
         // Make list view
         listViewArgs.$browser = $browser;