You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by mureinik <gi...@git.apache.org> on 2017/02/16 18:46:30 UTC
[GitHub] commons-lang pull request #236: Use StringBuilders instead of StringBuffers ...
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/236
Use StringBuilders instead of StringBuffers for local variables
Some old parts of the code, originally written before Java 5 was
available use StringBuffers in their local variables. Since local
variables pose no concurrency problems, they can safely be replaced
with non thread safe StringBuilders, for a slight performance gain.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mureinik/commons-lang StringBuilder
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/236.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #236
----
commit 2f6aa84a98a8e7a84049aa681ddda1feb2a40c7d
Author: Allon Mureinik <am...@redhat.com>
Date: 2017-02-16T18:39:27Z
Use StringBuilders instead of StringBuffers
Some old parts of the code, originally written before Java 5 was
available use StringBuffers in their local variables. Since local
variables pose no concurrency problems, they can safely be replaced
with non thread safe StringBuilders, for a slight performance gain.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #236: Use StringBuilders instead of StringBuffers for loc...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/236
[](https://coveralls.io/builds/10198814)
Coverage remained the same at 94.529% when pulling **2f6aa84a98a8e7a84049aa681ddda1feb2a40c7d on mureinik:StringBuilder** into **ce1bd5785d05d3df324e1169aab4abd45f4281f7 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #236: Use StringBuilders instead of StringBuffers ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---