You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by ericcarlschwartz <gi...@git.apache.org> on 2016/08/25 21:34:31 UTC
[GitHub] trafficserver pull request #928: Ts 4423
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/928
Ts 4423
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ericcarlschwartz/trafficserver TS-4423
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/928.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #928
----
commit 0edb246b0ca21e4151c0d3aa5e6f8e9757809c11
Author: Eric Schwartz <es...@inducedeuce.corp.gq1.yahoo.com>
Date: 2016-08-25T20:39:11Z
[TS-4423] Don't show function / filename / line numbers on "operational logs"
commit 578cd48ceab27e76f21a534d91127e33cb4fff14
Author: Eric Schwartz <es...@inducedeuce.corp.gq1.yahoo.com>
Date: 2016-08-25T21:31:16Z
Merge branch 'master' of https://github.com/apache/trafficserver into TS-4423
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #928: Ts 4423
Posted by ericcarlschwartz <gi...@git.apache.org>.
Github user ericcarlschwartz commented on the issue:
https://github.com/apache/trafficserver/pull/928
Dropped the merge commit and made an enum instead of magic numbers. What's wrong with the commit message @zwoop? I just grabbed the name from the bug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #928: [TS-4423] Update Show Location Options
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/928
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #928: Ts 4423
Posted by ericcarlschwartz <gi...@git.apache.org>.
Github user ericcarlschwartz commented on the issue:
https://github.com/apache/trafficserver/pull/928
Ah got it, will fix that up!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #928: [TS-4423] Update Show Location Options
Posted by ericcarlschwartz <gi...@git.apache.org>.
Github user ericcarlschwartz commented on the issue:
https://github.com/apache/trafficserver/pull/928
Ah, my mistake there. Didn't realize it'd autopopulated w/ something bad.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #928: Ts 4423
Posted by ericcarlschwartz <gi...@git.apache.org>.
Github user ericcarlschwartz commented on the issue:
https://github.com/apache/trafficserver/pull/928
That sounds good to me. Will try to adhere to in the future. I just went with "Update Show Location Options" for this guy
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #928: Ts 4423
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/928
Also update the commit message :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #928: Ts 4423
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/928
Cool. And this PR still needs some fixing too on the commit message :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #928: Ts 4423
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/928
Fwiw, Github sort of imposes a Subject length of 50 characters, it will line wrap beyond that, making for ugly messages. So, I think we should recommend
TS-1234 < 50 character Subject
Some longer text can come here.
With more lines, and longer lines, but still < 80 characters per line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #928: Ts 4423
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/928
The preferred commit message is:
```
TS-1234: less than 80 chars.
```
Feel free to add an extended explanation into the body of the commit message. It makes it easier than having to refer back to Jira tickets and pull requests.
I think @zwoop may have been referring to the PR subject, which should generally be the same as the leading commit. The PR subject shows up as a merge commit so it is worth making it nice :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #928: Ts 4423
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/928#discussion_r76329976
--- Diff: cmd/traffic_ctl/traffic_ctl.cc ---
@@ -240,7 +240,7 @@ main(int argc, const char **argv)
if (debug) {
diags->activate_taglist("traffic_ctl", DiagsTagType_Debug);
diags->config.enabled[DiagsTagType_Debug] = true;
- diags->show_location = true;
+ diags->show_location = 1;
--- End diff --
Can you please add constants to ``Diags.h`` for the ``show_location`` levels?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #928: [TS-4423] Update Show Location Options
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/928
meh we landed this without testing on the CI :-/. It breaks the builds.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #928: Ts 4423
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/928
Please rebase to remove the merge commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---