You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/06/28 18:20:35 UTC

[GitHub] [incubator-iceberg] electrum commented on issue #235: Ensure dependencies are consistent and reviewable via gradle-consistent-versions

electrum commented on issue #235: Ensure dependencies are consistent and reviewable via gradle-consistent-versions
URL: https://github.com/apache/incubator-iceberg/issues/235#issuecomment-506831767
 
 
   I'm new to Gradle, but I read through the docs for `gradle-consistent-versions` and it seems quite reasonable. It has some nice features that I'd like to have in Maven. This appears to be a strict improvement over the current situation.
   
   One problem this doesn't seem to solve is requiring dependency declarations for everything that is used directly. For example, before 37f6a20f324b23c26773b24259ee78d067d41323, the code was directly referencing `commons-compress`, but there was no direct dependency. The classes happened to be on the classpath via the `avro` dependency. This is solved in Maven via [`dependency:analyze`](https://maven.apache.org/plugins/maven-dependency-plugin/usage.html#The_dependency:analyze_mojo). The Gradle equivalent seems to be [gradle-dependency-analyze](https://github.com/wfhartford/gradle-dependency-analyze) although I'm surprised there's not a more "official" solution.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org