[jira] [Commented] (KAFKA-2615) Poll() method is broken wrt time

["Ewen Cheslack-Postava (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839112#comment-15839112 ] 

Ewen Cheslack-Postava commented on KAFKA-2615:
----------------------------------------------

Semi unintentionally, KAFKA-2677 ran into the issue of the `now` parameter not being valid after a poll and fixed the method to get an updated time, inadvertently fixing this issue in the process.

> Poll() method is broken wrt time
> --------------------------------
>
>                 Key: KAFKA-2615
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2615
>             Project: Kafka
>          Issue Type: Bug
>          Components: clients, consumer, producer 
>    Affects Versions: 0.8.2.1
>            Reporter: Eno Thereska
>            Assignee: Eno Thereska
>              Labels: patch
>             Fix For: 0.8.2.1
>
>
> Initially reported by [~ewencp] and discussed with [~hachikuji]. In NetworkClient.java, the poll() method receives as input a "now" parameter, does a whole bunch of work (e.g., selector.poll()) and then keeps using "now" in all the subsequent method calls. 
> Passing Time everywhere instead of "now" is a potential fix, but might be expensive since it's a new system call.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)