[GitHub] [hive] nrg4878 commented on a change in pull request #1906: Hive 24348 - Isolating dependencies and execution with Java for Beeline(Abhay Chennagiri)

[GitBox <gi...@apache.org>]

nrg4878 commented on a change in pull request #1906:
URL: https://github.com/apache/hive/pull/1906#discussion_r570353101



##########
File path: bin/hive
##########
@@ -89,15 +86,12 @@ if [ "$SERVICE" = "" ] ; then
   fi
 fi
 
+USE_BEELINE_FOR_HIVE_CLI="true"
 if [[ "$SERVICE" == "cli" && "$USE_BEELINE_FOR_HIVE_CLI" == "true" ]] ; then
   CLIUSER=`whoami`
   SERVICE="beeline"
 fi
 
-if [[ "$SERVICE" == "beeline" && ! -z "$BEELINE_URL_LEGACY" ]] ; then

Review comment:
       @achennagiri I am not sure why has this been deleted by me, but this should still be supported.
   
   This was added to enable beeline to automatically pick a connection string based on an environment variable (beeline profile). Could you add is back and test this functionality please?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org