You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by misakuo <gi...@git.apache.org> on 2017/11/28 02:33:58 UTC

[GitHub] incubator-weex pull request #915: [WEEX-148][Android] box-shadow support mul...

GitHub user misakuo opened a pull request:

    https://github.com/apache/incubator-weex/pull/915

    [WEEX-148][Android] box-shadow support multi shadows

    Testcase:
    http://dotwe.org/weex/f1d7342879a6d1f52ee85c9e810d8df9
    
    Expected effect:    
    ![img](https://img.alicdn.com/tfs/TB1nJyqfBHH8KJjy0FbXXcqlpXa-392-250.png)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/misakuo/incubator-weex android-feature-multi-shadows

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/915.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #915
    
----
commit a2c9a97a7a1becbe17efb5d1057ec98e715c4ba4
Author: misakuo <mi...@apache.org>
Date:   2017-11-13T03:37:08Z

    * [android] support role property to accessibility
    
    (cherry picked from commit c4721ba)

commit 670cd596197111b1a5a64befd8edc33cdc6cd0ec
Author: misakuo <mi...@apache.org>
Date:   2017-11-20T04:47:59Z

    * [android] add license header
    
    (cherry picked from commit 2aa3b95)

commit e30d333a38674d3d4ca252788149f3e4c51fdc6c
Author: misakuo <mi...@apache.org>
Date:   2017-11-20T07:06:13Z

    * [android] remove cn strings
    
    (cherry picked from commit 219d0e3)

commit bff78798c70713fa8c58cbbffba7e229710dcb8f
Author: misakuo <mi...@apache.org>
Date:   2017-11-27T03:04:02Z

    * [android] fix en role
    
    (cherry picked from commit 5fe0d9d)

commit 5d9aee2544acbed70d2720dc586399369a384237
Author: misakuo <mi...@apache.org>
Date:   2017-11-27T12:14:24Z

    Merge remote-tracking branch 'apache/master' into apache-master

commit 35d01e0451ba12f300f3f647cd7c6a69f639abc7
Author: misakuo <mi...@apache.org>
Date:   2017-11-13T03:37:08Z

    * [android] support multi box-shadow

commit 92ceb92cb02bc17b810fd31cc7e0520c808e1607
Author: misakuo <mi...@apache.org>
Date:   2017-11-13T03:37:08Z

    * [android] support multi box-shadow

----


---

[GitHub] incubator-weex issue #915: [WEEX-148][Android] box-shadow support multi shad...

Posted by gurisxie <gi...@git.apache.org>.
Github user gurisxie commented on the issue:

    https://github.com/apache/incubator-weex/pull/915
  
    please check whether it's ok. If yes, you need to change the base png for diff.
    ![image](https://user-images.githubusercontent.com/7436932/33300663-85d13d9a-d42c-11e7-9d1a-1b9845e57129.png)



---

[GitHub] incubator-weex pull request #915: [WEEX-148][Android] box-shadow support mul...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/915


---

[GitHub] incubator-weex issue #915: [WEEX-148][Android] box-shadow support multi shad...

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/915
  
    
    <!--
      0 failure: 
      3 warning:  No Changelog chan..., This PR should up..., Potential BREAK C...
      1 messages
      
    -->
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>This PR should update related documents as well. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/utils/BoxShadowUtil.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>danger test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---