You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/09/25 08:18:53 UTC
Review Request 38752: CMake: Transition Mesos to use new third-party
build scripts.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38752/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Transition Mesos to use new third-party build scripts.
Diffs
-----
3rdparty/libprocess/3rdparty/CMakeLists.txt b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d
cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8
Diff: https://reviews.apache.org/r/38752/diff/
Testing
-------
Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
* OS X 10.10
* Ubuntu 14.04.2
Thanks,
Alex Clemmer
Re: Review Request 38752: CMake: Transition Mesos to use new
third-party build scripts.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38752/#review100616
-----------------------------------------------------------
LGTM.
- Artem Harutyunyan
On Sept. 24, 2015, 11:18 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38752/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 11:18 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Transition Mesos to use new third-party build scripts.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/CMakeLists.txt b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d
> cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8
>
> Diff: https://reviews.apache.org/r/38752/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38752: CMake: Update MesosConfigure to use new
process configure scripts.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38752/
-----------------------------------------------------------
(Updated Sept. 26, 2015, 10:05 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Transition Mesos to use new third-party build scripts.
Diffs (updated)
-----
cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8
Diff: https://reviews.apache.org/r/38752/diff/
Testing
-------
Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
* OS X 10.10
* Ubuntu 14.04.2
Thanks,
Alex Clemmer
Re: Review Request 38752: CMake: Update MesosConfigure to use new
process configure scripts.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38752/#review100742
-----------------------------------------------------------
Ship it!
- Joris Van Remoortere
On Sept. 25, 2015, 10:12 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38752/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 10:12 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Transition Mesos to use new third-party build scripts.
>
>
> Diffs
> -----
>
> cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8
>
> Diff: https://reviews.apache.org/r/38752/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38752: CMake: Update MesosConfigure to use new
process configure scripts.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38752/
-----------------------------------------------------------
(Updated Sept. 25, 2015, 10:12 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Summary (updated)
-----------------
CMake: Update MesosConfigure to use new process configure scripts.
Repository: mesos
Description
-------
CMake: Transition Mesos to use new third-party build scripts.
Diffs (updated)
-----
cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8
Diff: https://reviews.apache.org/r/38752/diff/
Testing
-------
Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
* OS X 10.10
* Ubuntu 14.04.2
Thanks,
Alex Clemmer
Re: Review Request 38752: CMake: Update MesosConfigure to use new
process configure scripts.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Sept. 25, 2015, 8:29 p.m., Joris Van Remoortere wrote:
> > You'll need to split this up as it's touching 2 different projects:
> > ```
> > ERROR: Commit spanning multiple projects.
> >
> > Please use separate commits for mesos, libprocess and stout.
> >
> > Paths grouped by project:
> > mesos:
> > cmake/MesosConfigure.cmake
> > libprocess:
> > 3rdparty/libprocess/3rdparty/CMakeLists.txt
> > Failed to commit patch
> > ```
I decided the libprocess parts really belonged review #38751. Moving it, I think, fixes this issue.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38752/#review100676
-----------------------------------------------------------
On Sept. 25, 2015, 10:12 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38752/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 10:12 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Transition Mesos to use new third-party build scripts.
>
>
> Diffs
> -----
>
> cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8
>
> Diff: https://reviews.apache.org/r/38752/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38752: CMake: Transition Mesos to use new
third-party build scripts.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38752/#review100676
-----------------------------------------------------------
You'll need to split this up as it's touching 2 different projects:
```
ERROR: Commit spanning multiple projects.
Please use separate commits for mesos, libprocess and stout.
Paths grouped by project:
mesos:
cmake/MesosConfigure.cmake
libprocess:
3rdparty/libprocess/3rdparty/CMakeLists.txt
Failed to commit patch
```
- Joris Van Remoortere
On Sept. 25, 2015, 6:18 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38752/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 6:18 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Transition Mesos to use new third-party build scripts.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/CMakeLists.txt b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d
> cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8
>
> Diff: https://reviews.apache.org/r/38752/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38752: CMake: Transition Mesos to use new
third-party build scripts.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38752/#review100603
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Sept. 24, 2015, 11:18 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38752/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 11:18 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Transition Mesos to use new third-party build scripts.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/CMakeLists.txt b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d
> cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8
>
> Diff: https://reviews.apache.org/r/38752/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>