You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/18 18:32:31 UTC

[GitHub] [tvm] Lunderberg opened a new pull request #8071: [Codegen] Use "target.build.$TARGET_KIND" for all codegen functions.

Lunderberg opened a new pull request #8071:
URL: https://github.com/apache/tvm/pull/8071


   Noticed while writing documentation that not all codegen functions
   follow the same naming pattern.  Made changes below for consistency,
   ease of locating a codegen function.
   
   - Removed special case for "micro_dev" target.  Instead, register
     BuildCHost as both "target.build.c" and "target.build.micro_dev".
   
   - Renamed "target.build.build.aocl_sw_emu" to
     "target.build.aocl_sw_emu".  Appears to be a typo introduced in
     #841725cc585
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #8071: [Codegen] Use "target.build.$TARGET_KIND" for all codegen functions.

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #8071:
URL: https://github.com/apache/tvm/pull/8071#issuecomment-844259260


   @Lunderberg yeah `micro_dev` can go away now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Lunderberg commented on pull request #8071: [Codegen] Use "target.build.$TARGET_KIND" for all codegen functions.

Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #8071:
URL: https://github.com/apache/tvm/pull/8071#issuecomment-844252181


   @areusch On second thought, it looks like the special case for a `micro_dev` target should be removed rather than implemented elsewhere, since your commit 745e542e4deaf44f3d6e5665299aa85ef8f4a6b9 removed the `micro_dev` target entirely.  Is that correct?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Lunderberg commented on pull request #8071: [Codegen] Use "target.build.$TARGET_KIND" for all codegen functions.

Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #8071:
URL: https://github.com/apache/tvm/pull/8071#issuecomment-852212222


   Thank you!  Rebased this morning to remove conflict with main, no other changes made from the approved version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Lunderberg edited a comment on pull request #8071: [Codegen] Use "target.build.$TARGET_KIND" for all codegen functions.

Posted by GitBox <gi...@apache.org>.
Lunderberg edited a comment on pull request #8071:
URL: https://github.com/apache/tvm/pull/8071#issuecomment-844561201


   @areusch Awesome.  In that case, removing the special case for `micro_dev`, and removing lots of other references to avoid any future confusion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch merged pull request #8071: [Codegen] Use "target.build.$TARGET_KIND" for all codegen functions.

Posted by GitBox <gi...@apache.org>.
areusch merged pull request #8071:
URL: https://github.com/apache/tvm/pull/8071


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Lunderberg commented on pull request #8071: [Codegen] Use "target.build.$TARGET_KIND" for all codegen functions.

Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #8071:
URL: https://github.com/apache/tvm/pull/8071#issuecomment-844561201


   @areusch Awesome.  In that case, removing the special case for `micro_dev`, and removing lots of other references so that it doesn't trip people up in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Lunderberg commented on pull request #8071: [Codegen] Use "target.build.$TARGET_KIND" for all codegen functions.

Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #8071:
URL: https://github.com/apache/tvm/pull/8071#issuecomment-847991625


   Potential reviewers: @areusch @tqchen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org