You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/19 12:43:07 UTC
[GitHub] [dubbo-go] zhaoyunxing92 opened a new pull request #1602: add:go imports tool
zhaoyunxing92 opened a new pull request #1602:
URL: https://github.com/apache/dubbo-go/pull/1602
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
**What this PR does**:
添加格式化工具
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1602: add:go imports tool
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #1602:
URL: https://github.com/apache/dubbo-go/pull/1602#issuecomment-974045434
What's the reason of this ci failed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1602: add:go imports tool
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1602:
URL: https://github.com/apache/dubbo-go/pull/1602#issuecomment-977686108
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1602?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1602](https://codecov.io/gh/apache/dubbo-go/pull/1602?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea049db) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/cc201e9a19eefdcff6f2e6e773fc92eca39fad95?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cc201e9) will **decrease** coverage by `0.21%`.
> The diff coverage is `24.89%`.
> :exclamation: Current head ea049db differs from pull request most recent head a9a43e1. Consider uploading reports for the commit a9a43e1 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1602?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1602 +/- ##
==========================================
- Coverage 41.20% 40.99% -0.22%
==========================================
Files 250 251 +1
Lines 14264 14403 +139
==========================================
+ Hits 5877 5904 +27
- Misses 7703 7816 +113
+ Partials 684 683 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1602?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.43% <ø> (ø)` | |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `13.69% <0.00%> (-0.39%)` | :arrow_down: |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `21.42% <0.00%> (-3.32%)` | :arrow_down: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `0.00% <0.00%> (ø)` | |
| [config/tracing\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3RyYWNpbmdfY29uZmlnLmdv) | `0.00% <0.00%> (ø)` | |
| [filter/accesslog/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2FjY2Vzc2xvZy9maWx0ZXIuZ28=) | `32.77% <0.00%> (-0.57%)` | :arrow_down: |
| [metadata/service/local/service.go](https://codecov.io/gh/apache/dubbo-go/pull/1602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvc2VydmljZS9sb2NhbC9zZXJ2aWNlLmdv) | `73.52% <ø> (ø)` | |
| [protocol/dubbo/dubbo\_codec.go](https://codecov.io/gh/apache/dubbo-go/pull/1602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fY29kZWMuZ28=) | `1.87% <ø> (ø)` | |
| [protocol/dubbo/hessian2/hessian\_response.go](https://codecov.io/gh/apache/dubbo-go/pull/1602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaGVzc2lhbjIvaGVzc2lhbl9yZXNwb25zZS5nbw==) | `54.58% <ø> (ø)` | |
| [protocol/dubbo/impl/serialize.go](https://codecov.io/gh/apache/dubbo-go/pull/1602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9zZXJpYWxpemUuZ28=) | `0.00% <ø> (ø)` | |
| ... and [22 more](https://codecov.io/gh/apache/dubbo-go/pull/1602/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1602?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1602?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [03cf5fd...a9a43e1](https://codecov.io/gh/apache/dubbo-go/pull/1602?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zhaoyunxing92 commented on pull request #1602: add:go imports tool
Posted by GitBox <gi...@apache.org>.
zhaoyunxing92 commented on pull request #1602:
URL: https://github.com/apache/dubbo-go/pull/1602#issuecomment-977692604
> What's the reason of this ci failed?
需要修改tools那边代码，最后结尾空格问题
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zhaoyunxing92 merged pull request #1602: add:go imports tool
Posted by GitBox <gi...@apache.org>.
zhaoyunxing92 merged pull request #1602:
URL: https://github.com/apache/dubbo-go/pull/1602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org