You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/17 05:46:39 UTC

[GitHub] [kafka] ijuma commented on a diff in pull request #13001: KAFKA-14446: code style improvements for broker-to-controller forwarding

ijuma commented on code in PR #13001:
URL: https://github.com/apache/kafka/pull/13001#discussion_r1051321610


##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -703,8 +703,8 @@ class KafkaServer(
                 case None =>
                   info(s"Broker registration for controller $controllerId is not available in the metadata cache")
               }
-            case None =>
-              info("No controller present in the metadata cache")
+            case Some(_: KRaftCachedControllerId) | None =>

Review Comment:
   Hmm, looks like you replaced an exhaustive pattern matching block with a non exhaustive one? Am I missing something?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org