You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/10/21 12:07:15 UTC

[GitHub] [nifi-minifi-cpp] adamdebreceni opened a new pull request #1204: MINIFICPP-1670 - Sever http-curl's civet dependency

adamdebreceni opened a new pull request #1204:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1204


   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits commented on pull request #1204: MINIFICPP-1670 - Sever http-curl's civet dependency

Posted by GitBox <gi...@apache.org>.
fgerlits commented on pull request #1204:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1204#issuecomment-951745893


   We use `RESTReceiver` in some tests in `extensions/http-curl/tests/`.  How do those work now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits edited a comment on pull request #1204: MINIFICPP-1670 - Sever http-curl's civet dependency

Posted by GitBox <gi...@apache.org>.
fgerlits edited a comment on pull request #1204:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1204#issuecomment-951745893


   We use `RESTReceiver` in some tests in `extensions/http-curl/tests/`.  How do those work now?
   
   EDIT: never mind, the tests still depend on `minifi-civet-extensions`, which is OK.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #1204: MINIFICPP-1670 - Sever http-curl's civet dependency

Posted by GitBox <gi...@apache.org>.
szaszm commented on pull request #1204:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1204#issuecomment-951766606


   > We use `RESTReceiver` in some tests in `extensions/http-curl/tests/`. How do those work now?
   
   We link the civetweb extension to curl tests, just not the curl extension.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] adamdebreceni closed pull request #1204: MINIFICPP-1670 - Sever http-curl's civet dependency

Posted by GitBox <gi...@apache.org>.
adamdebreceni closed pull request #1204:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1204


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org