[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6792: Support multiple ceph monitors

[GitBox <gi...@apache.org>]

weizhouapache commented on code in PR #6792:
URL: https://github.com/apache/cloudstack/pull/6792#discussion_r984591419


##########
plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java:
##########
@@ -238,6 +238,39 @@ public void testDiskDefWithEncryption() {
         assertEquals(disk.toString(), expectedXML);
     }
 
+    @Test
+    public void testDiskDefWithMultipleHosts() {
+        String path = "/mnt/primary1";
+        String host = "10.11.12.13,10.11.12.14,10.11.12.15";

Review Comment:
   @wido 
   It seems monitor with ipv6 address is not suported in this PR.
   
   what is currently supported and any issue in following scenarios ?
   - ipv6 addr without port
   - ipv6 addr with port
   I do not have a ceph env with ipv6 address , it is difficult to verify.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org