You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/21 16:16:40 UTC
[GitHub] [maven-surefire] wilx opened a new pull request, #571: [SUREFIRE-2121] JUnitException: Failed to parse version of junit:junit: 4.13.2
wilx opened a new pull request, #571:
URL: https://github.com/apache/maven-surefire/pull/571
This pull request updates JUnit5 dependencies including its Vintage engine to current to fix the bug where it is unable to parse junit 4.13.2 version number.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #571: [SUREFIRE-2121] JUnitException: Failed to parse version of junit:junit: 4.13.2
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #571:
URL: https://github.com/apache/maven-surefire/pull/571#issuecomment-1461050822
@wilx thanks for effort.
@andpab thanks for summary issues to close.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] wilx commented on pull request #571: [SUREFIRE-2121] JUnitException: Failed to parse version of junit:junit: 4.13.2
Posted by GitBox <gi...@apache.org>.
wilx commented on PR #571:
URL: https://github.com/apache/maven-surefire/pull/571#issuecomment-1287262009
OK. I was too quick. It fixes the test for me but it breaks other parts of surefire because of API changes in Jupiter Engine. I am not sure I know how to deal with those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #571: [SUREFIRE-2121] JUnitException: Failed to parse version of junit:junit: 4.13.2
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #571:
URL: https://github.com/apache/maven-surefire/pull/571#issuecomment-1432703984
I assume that it can be closed - right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] andpab commented on pull request #571: [SUREFIRE-2121] JUnitException: Failed to parse version of junit:junit: 4.13.2
Posted by GitBox <gi...@apache.org>.
andpab commented on PR #571:
URL: https://github.com/apache/maven-surefire/pull/571#issuecomment-1367265046
As described in my comment in SUREFIRE-2121, this pull request does not address the root cause of the issue which is simply a configuration error. There is no need to update the JUnit 5 version used internally by Surefire.
It might however be a good idea to update the JUnit 4 version and the junit-vintage-engine dependency in some of the tests as well as in the documentation to avoid similar misconceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] andpab commented on pull request #571: [SUREFIRE-2121] JUnitException: Failed to parse version of junit:junit: 4.13.2
Posted by "andpab (via GitHub)" <gi...@apache.org>.
andpab commented on PR #571:
URL: https://github.com/apache/maven-surefire/pull/571#issuecomment-1433635709
Definitely. The corresponding JIRA issue SUREFIRE-2121 can also be closed as Won't Fix.
If you're in the process of cleaning up, the PR #493 can be closed as well. And the respective issue SUREFIRE-2039 can be closed as a duplicate of SUREFIRE-2032.
The following issues have apparently been fixed according to the comments:
- SUREFIRE-2096 (fixed in 3.0.0-M8)
- SUREFIRE-2094 (fixed in 3.0.0-M8)
- SUREFIRE-2068 (fixed in 3.0.0-M7)
There are also a couple of other issues that in my opinion can be closed as Won't Fix:
- SUREFIRE-2120
- SUREFIRE-2115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski closed pull request #571: [SUREFIRE-2121] JUnitException: Failed to parse version of junit:junit: 4.13.2
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski closed pull request #571: [SUREFIRE-2121] JUnitException: Failed to parse version of junit:junit: 4.13.2
URL: https://github.com/apache/maven-surefire/pull/571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] andpab commented on pull request #571: [SUREFIRE-2121] JUnitException: Failed to parse version of junit:junit: 4.13.2
Posted by GitBox <gi...@apache.org>.
andpab commented on PR #571:
URL: https://github.com/apache/maven-surefire/pull/571#issuecomment-1371271421
I've updated the versions in SUREFIRE-2138 (PR #590), so once the next release is made, the examples on the website will show up-to-date versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org