You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2020/11/16 13:08:20 UTC

[GitHub] [james-project] chibenwa commented on a change in pull request #261: JAMES-1902 reorganizes blob modules

chibenwa commented on a change in pull request #261:
URL: https://github.com/apache/james-project/pull/261#discussion_r524253411



##########
File path: server/container/guice/blob/blob-api-guice/pom.xml
##########
@@ -25,7 +25,7 @@
         <groupId>org.apache.james</groupId>
         <artifactId>james-server-guice</artifactId>
         <version>3.6.0-SNAPSHOT</version>
-        <relativePath>../pom.xml</relativePath>
+        <relativePath>../../pom.xml</relativePath>

Review comment:
       Does it makes sense to keep the blob- prefix for folders inside a blob directory? Idem for the guice suffix.
   
   Shouldn't the naming scheme be guice/blob/api ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org