You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/22 09:20:14 UTC

[GitHub] [skywalking-java] songhao1105 commented on a diff in pull request #95: Support thread pool metric collect

songhao1105 commented on code in PR #95:
URL: https://github.com/apache/skywalking-java/pull/95#discussion_r855967282


##########
CHANGES.md:
##########
@@ -4,7 +4,7 @@ Release Notes.
 
 8.10.0
 ------------------
-
+* Support Java thread pool metric collect.

Review Comment:
   @wu-sheng There are many thread pools in my project, such as ThreadPoolA and ThreadPoolB. If I want to monitor the metrics of these two thread pools separately, do I need to add a new plugin to the agent and two rules to the threadpool.ymal of OAP like:
   \- name: ThreadPoolA
     exp: ThreadPoolA.avg(['metric_type', 'pool_name', 'instance', 'service'])
   \- name: ThreadPoolB
     exp: ThreadPoolB.avg(['metric_type', 'pool_name', 'instance', 'service'])



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org