You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Carsten Karkola (JIRA)" <ji...@codehaus.org> on 2006/06/02 16:59:43 UTC

[jira] Created: (MRAR-9) Avoid to bundle rar dependencies (w/o scope=provided) inside the rar archive

Avoid to bundle rar dependencies (w/o scope=provided) inside the rar archive
----------------------------------------------------------------------------

         Key: MRAR-9
         URL: http://jira.codehaus.org/browse/MRAR-9
     Project: Maven 2.x Rar Plugin
        Type: New Feature

    Versions: 2.2    
 Environment: Maven 2.0.4
    Reporter: Carsten Karkola


If I use "provided" the dependencies will never be included, my problem is
1. projects:
my-jar
rar1: dependency to my-jar
rar2: dependency to my-jar
ejb1: dependency to my-jar
ear: dependency to rar1, rar2. ejb1
2. inside the ear:
ejb1.jar
rar1.rar
rar2.rar
lib/my-jar.jar
3. This works fine for packaging=ejb - the my-jar.jar gets copied to the lib dir during build of
the ear. But the same jar gets also packaged in the rar1 and in the rar2 archive. So I have it
three times instead only having the entries in MANFIFEST.MF/Class-Path and the jar only
once in the lib subdir.
The Manifest entries are not the problem, to get the jar not packaged in the rars is my
problem.

4. my proposal:
add plugin configuration parameter <includeDependencies>false</includeDependencies>

in RarMojo.java additional parameter and check:

/**

    * Specify if the specified dependencies of this project should be
    * included in the rar file ; default is true.
      *
    * @parameter
      */
      private Boolean includeDependencies = Boolean.TRUE;

....
// Copy dependencies
try
{
if (includeDependencies.booleanValue()) { // additional check

carsten

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MRAR-9) Avoid to bundle rar dependencies (w/o scope=provided) inside the rar archive

Posted by "Benjamin (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRAR-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159597#action_159597 ] 

Benjamin commented on MRAR-9:
-----------------------------

I agree with Carsten, this change is of high priority and i believe a simple flag is the best way to accomplish it. there are almost no scenarios where one would want to include some JAR dependencies inside the RAR and others at the EAR level. even if multiple versions of the same library are needed then simple renaming of different jar dependencies and using the RAR manifest file's classpath entry would allow one to accomplish this.

> Avoid to bundle rar dependencies (w/o scope=provided) inside the rar archive
> ----------------------------------------------------------------------------
>
>                 Key: MRAR-9
>                 URL: http://jira.codehaus.org/browse/MRAR-9
>             Project: Maven 2.x Rar Plugin
>          Issue Type: New Feature
>    Affects Versions: 2.1
>         Environment: Maven 2.0.4
>            Reporter: Carsten Karkola
>            Assignee: Stephane Nicoll
>             Fix For: 2.3
>
>
> If I use "provided" the dependencies will never be included, my problem is
> 1. projects:
> my-jar
> rar1: dependency to my-jar
> rar2: dependency to my-jar
> ejb1: dependency to my-jar
> ear: dependency to rar1, rar2. ejb1
> 2. inside the ear:
> ejb1.jar
> rar1.rar
> rar2.rar
> lib/my-jar.jar
> 3. This works fine for packaging=ejb - the my-jar.jar gets copied to the lib dir during build of
> the ear. But the same jar gets also packaged in the rar1 and in the rar2 archive. So I have it
> three times instead only having the entries in MANFIFEST.MF/Class-Path and the jar only
> once in the lib subdir.
> The Manifest entries are not the problem, to get the jar not packaged in the rars is my
> problem.
> 4. my proposal:
> add plugin configuration parameter <includeDependencies>false</includeDependencies>
> in RarMojo.java additional parameter and check:
> /**
>     * Specify if the specified dependencies of this project should be
>     * included in the rar file ; default is true.
>       *
>     * @parameter
>       */
>       private Boolean includeDependencies = Boolean.TRUE;
> ....
> // Copy dependencies
> try
> {
> if (includeDependencies.booleanValue()) { // additional check
> carsten

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MRAR-9) Avoid to bundle rar dependencies (w/o scope=provided) inside the rar archive

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
     [ https://jira.codehaus.org/browse/MRAR-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Lamy updated MRAR-9:
----------------------------

    Fix Version/s:     (was: 2.3)
                   2.4
    
> Avoid to bundle rar dependencies (w/o scope=provided) inside the rar archive
> ----------------------------------------------------------------------------
>
>                 Key: MRAR-9
>                 URL: https://jira.codehaus.org/browse/MRAR-9
>             Project: Maven 2.x Rar Plugin
>          Issue Type: New Feature
>    Affects Versions: 2.1
>         Environment: Maven 2.0.4
>            Reporter: Carsten Karkola
>            Assignee: Stéphane Nicoll
>             Fix For: 2.4
>
>
> If I use "provided" the dependencies will never be included, my problem is
> 1. projects:
> my-jar
> rar1: dependency to my-jar
> rar2: dependency to my-jar
> ejb1: dependency to my-jar
> ear: dependency to rar1, rar2. ejb1
> 2. inside the ear:
> ejb1.jar
> rar1.rar
> rar2.rar
> lib/my-jar.jar
> 3. This works fine for packaging=ejb - the my-jar.jar gets copied to the lib dir during build of
> the ear. But the same jar gets also packaged in the rar1 and in the rar2 archive. So I have it
> three times instead only having the entries in MANFIFEST.MF/Class-Path and the jar only
> once in the lib subdir.
> The Manifest entries are not the problem, to get the jar not packaged in the rars is my
> problem.
> 4. my proposal:
> add plugin configuration parameter <includeDependencies>false</includeDependencies>
> in RarMojo.java additional parameter and check:
> /**
>     * Specify if the specified dependencies of this project should be
>     * included in the rar file ; default is true.
>       *
>     * @parameter
>       */
>       private Boolean includeDependencies = Boolean.TRUE;
> ....
> // Copy dependencies
> try
> {
> if (includeDependencies.booleanValue()) { // additional check
> carsten

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (MRAR-9) Avoid to bundle rar dependencies (w/o scope=provided) inside the rar archive

Posted by "Dave Meibusch (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRAR-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_112418 ] 

Dave Meibusch commented on MRAR-9:
----------------------------------

Perhaps a solution mirroring the ear plugin functionality: http://maven.apache.org/plugins/maven-ear-plugin/examples/excluding-a-module.html


> Avoid to bundle rar dependencies (w/o scope=provided) inside the rar archive
> ----------------------------------------------------------------------------
>
>                 Key: MRAR-9
>                 URL: http://jira.codehaus.org/browse/MRAR-9
>             Project: Maven 2.x Rar Plugin
>          Issue Type: New Feature
>    Affects Versions: 2.1
>         Environment: Maven 2.0.4
>            Reporter: Carsten Karkola
>            Assignee: Stephane Nicoll
>             Fix For: 2.3
>
>
> If I use "provided" the dependencies will never be included, my problem is
> 1. projects:
> my-jar
> rar1: dependency to my-jar
> rar2: dependency to my-jar
> ejb1: dependency to my-jar
> ear: dependency to rar1, rar2. ejb1
> 2. inside the ear:
> ejb1.jar
> rar1.rar
> rar2.rar
> lib/my-jar.jar
> 3. This works fine for packaging=ejb - the my-jar.jar gets copied to the lib dir during build of
> the ear. But the same jar gets also packaged in the rar1 and in the rar2 archive. So I have it
> three times instead only having the entries in MANFIFEST.MF/Class-Path and the jar only
> once in the lib subdir.
> The Manifest entries are not the problem, to get the jar not packaged in the rars is my
> problem.
> 4. my proposal:
> add plugin configuration parameter <includeDependencies>false</includeDependencies>
> in RarMojo.java additional parameter and check:
> /**
>     * Specify if the specified dependencies of this project should be
>     * included in the rar file ; default is true.
>       *
>     * @parameter
>       */
>       private Boolean includeDependencies = Boolean.TRUE;
> ....
> // Copy dependencies
> try
> {
> if (includeDependencies.booleanValue()) { // additional check
> carsten

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRAR-9) Avoid to bundle rar dependencies (w/o scope=provided) inside the rar archive

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRAR-9?page=all ]

Stephane Nicoll updated MRAR-9:
-------------------------------

    Affects Version/s:     (was: 2.2)
                       2.1

> Avoid to bundle rar dependencies (w/o scope=provided) inside the rar archive
> ----------------------------------------------------------------------------
>
>                 Key: MRAR-9
>                 URL: http://jira.codehaus.org/browse/MRAR-9
>             Project: Maven 2.x Rar Plugin
>          Issue Type: New Feature
>    Affects Versions: 2.1
>         Environment: Maven 2.0.4
>            Reporter: Carsten Karkola
>
> If I use "provided" the dependencies will never be included, my problem is
> 1. projects:
> my-jar
> rar1: dependency to my-jar
> rar2: dependency to my-jar
> ejb1: dependency to my-jar
> ear: dependency to rar1, rar2. ejb1
> 2. inside the ear:
> ejb1.jar
> rar1.rar
> rar2.rar
> lib/my-jar.jar
> 3. This works fine for packaging=ejb - the my-jar.jar gets copied to the lib dir during build of
> the ear. But the same jar gets also packaged in the rar1 and in the rar2 archive. So I have it
> three times instead only having the entries in MANFIFEST.MF/Class-Path and the jar only
> once in the lib subdir.
> The Manifest entries are not the problem, to get the jar not packaged in the rars is my
> problem.
> 4. my proposal:
> add plugin configuration parameter <includeDependencies>false</includeDependencies>
> in RarMojo.java additional parameter and check:
> /**
>     * Specify if the specified dependencies of this project should be
>     * included in the rar file ; default is true.
>       *
>     * @parameter
>       */
>       private Boolean includeDependencies = Boolean.TRUE;
> ....
> // Copy dependencies
> try
> {
> if (includeDependencies.booleanValue()) { // additional check
> carsten

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRAR-9) Avoid to bundle rar dependencies (w/o scope=provided) inside the rar archive

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRAR-9?page=all ]

Stephane Nicoll updated MRAR-9:
-------------------------------

    Fix Version/s: 2.3

OK, not an easy one so I'll do it for the next release. I don't lile your binary solution, it certainly fit your need but it's not a general solution.

> Avoid to bundle rar dependencies (w/o scope=provided) inside the rar archive
> ----------------------------------------------------------------------------
>
>                 Key: MRAR-9
>                 URL: http://jira.codehaus.org/browse/MRAR-9
>             Project: Maven 2.x Rar Plugin
>          Issue Type: New Feature
>    Affects Versions: 2.1
>         Environment: Maven 2.0.4
>            Reporter: Carsten Karkola
>         Assigned To: Stephane Nicoll
>             Fix For: 2.3
>
>
> If I use "provided" the dependencies will never be included, my problem is
> 1. projects:
> my-jar
> rar1: dependency to my-jar
> rar2: dependency to my-jar
> ejb1: dependency to my-jar
> ear: dependency to rar1, rar2. ejb1
> 2. inside the ear:
> ejb1.jar
> rar1.rar
> rar2.rar
> lib/my-jar.jar
> 3. This works fine for packaging=ejb - the my-jar.jar gets copied to the lib dir during build of
> the ear. But the same jar gets also packaged in the rar1 and in the rar2 archive. So I have it
> three times instead only having the entries in MANFIFEST.MF/Class-Path and the jar only
> once in the lib subdir.
> The Manifest entries are not the problem, to get the jar not packaged in the rars is my
> problem.
> 4. my proposal:
> add plugin configuration parameter <includeDependencies>false</includeDependencies>
> in RarMojo.java additional parameter and check:
> /**
>     * Specify if the specified dependencies of this project should be
>     * included in the rar file ; default is true.
>       *
>     * @parameter
>       */
>       private Boolean includeDependencies = Boolean.TRUE;
> ....
> // Copy dependencies
> try
> {
> if (includeDependencies.booleanValue()) { // additional check
> carsten

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira