You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/09/16 01:36:29 UTC
[kudu-CR] c++ client: use entire deadline when retrying single-master DDL operations
Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4435
to review the following change.
Change subject: c++ client: use entire deadline when retrying single-master DDL operations
......................................................................
c++ client: use entire deadline when retrying single-master DDL operations
I was perplexed when I saw a new test that uses TestWorkload timeout in
CreateTable() after only 10s when the default admin operation timeout is
30s. Turns out, it's an actual bug in the client.
Of course, if CreateTable() is retried after 10s of waiting, it'll get
either ServiceUnavailable() or AlreadyPresent() until KUDU-1537 is fixed.
Change-Id: I23e6312bc014d59da04a0653d85d8ab1612d78d1
---
M src/kudu/client/client-internal.cc
M src/kudu/integration-tests/test_workload.cc
2 files changed, 11 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/4435/1
--
To view, visit http://gerrit.cloudera.org:8080/4435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I23e6312bc014d59da04a0653d85d8ab1612d78d1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
[kudu-CR] c++ client: use entire deadline when retrying single-master DDL operations
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: c++ client: use entire deadline when retrying single-master DDL operations
......................................................................
Patch Set 2: Verified+1
Spurious failure in ITClient test.
--
To view, visit http://gerrit.cloudera.org:8080/4435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23e6312bc014d59da04a0653d85d8ab1612d78d1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] c++ client: use entire deadline when retrying single-master DDL operations
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: c++ client: use entire deadline when retrying single-master DDL operations
......................................................................
c++ client: use entire deadline when retrying single-master DDL operations
I was perplexed when I saw a new test that uses TestWorkload timeout in
CreateTable() after only 10s when the default admin operation timeout is
30s. Turns out, it's an actual bug in the client.
Of course, if CreateTable() is retried after 10s of waiting, it'll get
either ServiceUnavailable() or AlreadyPresent() until KUDU-1537 is fixed.
Change-Id: I23e6312bc014d59da04a0653d85d8ab1612d78d1
Reviewed-on: http://gerrit.cloudera.org:8080/4435
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M src/kudu/client/client-internal.cc
M src/kudu/integration-tests/test_workload.cc
2 files changed, 11 insertions(+), 7 deletions(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Adar Dembo: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I23e6312bc014d59da04a0653d85d8ab1612d78d1
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Tidy Bot
[kudu-CR] c++ client: use entire deadline when retrying single-master DDL operations
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: c++ client: use entire deadline when retrying single-master DDL operations
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23e6312bc014d59da04a0653d85d8ab1612d78d1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] c++ client: use entire deadline when retrying single-master DDL operations
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4435
to look at the new patch set (#2).
Change subject: c++ client: use entire deadline when retrying single-master DDL operations
......................................................................
c++ client: use entire deadline when retrying single-master DDL operations
I was perplexed when I saw a new test that uses TestWorkload timeout in
CreateTable() after only 10s when the default admin operation timeout is
30s. Turns out, it's an actual bug in the client.
Of course, if CreateTable() is retried after 10s of waiting, it'll get
either ServiceUnavailable() or AlreadyPresent() until KUDU-1537 is fixed.
Change-Id: I23e6312bc014d59da04a0653d85d8ab1612d78d1
---
M src/kudu/client/client-internal.cc
M src/kudu/integration-tests/test_workload.cc
2 files changed, 11 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/4435/2
--
To view, visit http://gerrit.cloudera.org:8080/4435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I23e6312bc014d59da04a0653d85d8ab1612d78d1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot