You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by okram <gi...@git.apache.org> on 2016/10/31 19:25:19 UTC
[GitHub] tinkerpop pull request #472: TINKERPOP-1508: Add choose(predicate,trueTraver...
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/472
TINKERPOP-1508: Add choose(predicate,trueTraversal)
https://issues.apache.org/jira/browse/TINKERPOP-1508
Added `GraphTraversal.choose(predicate,traversal)` and `GraphTraversal.choose(traversal,traversal)`. These are implemented as `choose(traversal,identity())`. Up to this point, `choose()` has been if/then/else-semantics and now with addition, we have if/then-semantics.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1508
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/472.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #472
----
commit 659865bdb1a5e2db9e01847eb641101cab3d090a
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-10-31T19:23:42Z
added choose(predicate,traversal) which is a map to choose(predicate,traversal,identity()) and gives us if/then-semantics instead of always requiring if/then/else-semantics.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #472: TINKERPOP-1508: Add choose(predicate,trueTraver...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/472#discussion_r85862272
--- Diff: gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/ChooseStepTest.java ---
@@ -38,7 +42,10 @@
return Arrays.asList(
__.choose(values("name")).option("marko", out()).option(none, in()),
__.choose(values("name")).option("marko", in()).option(none, out()),
- __.choose(values("name")).option("josh", out()).option(none, in())
+ __.choose(values("name")).option("josh", out()).option(none, in()),
+ __.choose(out("knows").is(P.gt(0)), out("knows"), out("knows")),
+ __.choose(out("knows").is(P.gt(0)), out("knows"), out("created")),
+ __.choose(out("knows").is(P.gt(0)), out("knows"))
--- End diff --
Yea, I meant `count()`. I can add it before merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #472: TINKERPOP-1508: Add choose(predicate,trueTraver...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/472#discussion_r85858468
--- Diff: gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/ChooseStepTest.java ---
@@ -38,7 +42,10 @@
return Arrays.asList(
__.choose(values("name")).option("marko", out()).option(none, in()),
__.choose(values("name")).option("marko", in()).option(none, out()),
- __.choose(values("name")).option("josh", out()).option(none, in())
+ __.choose(values("name")).option("josh", out()).option(none, in()),
+ __.choose(out("knows").is(P.gt(0)), out("knows"), out("knows")),
+ __.choose(out("knows").is(P.gt(0)), out("knows"), out("created")),
+ __.choose(out("knows").is(P.gt(0)), out("knows"))
--- End diff --
It's pretty irrelevant for these tests, but `out("knows").is(gt(0))` makes no sense at all. Was it meant to be `out("knows").count().is(gt(0))`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #472: TINKERPOP-1508: Add choose(predicate,trueTraversal)
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/472
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #472: TINKERPOP-1508: Add choose(predicate,trueTraversal)
Posted by PommeVerte <gi...@git.apache.org>.
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/472
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #472: TINKERPOP-1508: Add choose(predicate,trueTraver...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/472
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---