You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2019/04/15 00:18:15 UTC

[Impala-ASF-CR] IMPALA-8412: Bump ORC to 1.5.5

Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13015


Change subject: IMPALA-8412: Bump ORC to 1.5.5
......................................................................

IMPALA-8412: Bump ORC to 1.5.5

Change-Id: Ife1dae6ec9928d81ede460bf79d5e48273ba731c
Testing: Ran the scanner tests on orc/def locally.
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/13015/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife1dae6ec9928d81ede460bf79d5e48273ba731c
Gerrit-Change-Number: 13015
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>

[Impala-ASF-CR] IMPALA-8412: Bump ORC to 1.5.5

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13015 )

Change subject: IMPALA-8412: Bump ORC to 1.5.5
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife1dae6ec9928d81ede460bf79d5e48273ba731c
Gerrit-Change-Number: 13015
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Apr 2019 17:23:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8412: Bump ORC to 1.5.5

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13015 )

Change subject: IMPALA-8412: Bump ORC to 1.5.5
......................................................................

IMPALA-8412: Bump ORC to 1.5.5

Testing: Ran the scanner tests on orc/def locally.

Change-Id: Ife1dae6ec9928d81ede460bf79d5e48273ba731c
Reviewed-on: http://gerrit.cloudera.org:8080/13015
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife1dae6ec9928d81ede460bf79d5e48273ba731c
Gerrit-Change-Number: 13015
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-8412: Bump ORC to 1.5.5

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13015 )

Change subject: IMPALA-8412: Bump ORC to 1.5.5
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife1dae6ec9928d81ede460bf79d5e48273ba731c
Gerrit-Change-Number: 13015
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Apr 2019 17:23:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8412: Bump ORC to 1.5.5

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13015 )

Change subject: IMPALA-8412: Bump ORC to 1.5.5
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4021/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife1dae6ec9928d81ede460bf79d5e48273ba731c
Gerrit-Change-Number: 13015
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Apr 2019 17:23:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8412: Bump ORC to 1.5.5

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13015 )

Change subject: IMPALA-8412: Bump ORC to 1.5.5
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife1dae6ec9928d81ede460bf79d5e48273ba731c
Gerrit-Change-Number: 13015
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Apr 2019 22:34:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8412: Bump ORC to 1.5.5

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13015 )

Change subject: IMPALA-8412: Bump ORC to 1.5.5
......................................................................


Patch Set 2: Code-Review+2

LGTM


-- 
To view, visit http://gerrit.cloudera.org:8080/13015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife1dae6ec9928d81ede460bf79d5e48273ba731c
Gerrit-Change-Number: 13015
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Apr 2019 03:02:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8412: Bump ORC to 1.5.5

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13015 )

Change subject: IMPALA-8412: Bump ORC to 1.5.5
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2775/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife1dae6ec9928d81ede460bf79d5e48273ba731c
Gerrit-Change-Number: 13015
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Apr 2019 01:02:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8412: Bump ORC to 1.5.5

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Tim Armstrong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13015

to look at the new patch set (#2).

Change subject: IMPALA-8412: Bump ORC to 1.5.5
......................................................................

IMPALA-8412: Bump ORC to 1.5.5

Testing: Ran the scanner tests on orc/def locally.

Change-Id: Ife1dae6ec9928d81ede460bf79d5e48273ba731c
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/13015/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife1dae6ec9928d81ede460bf79d5e48273ba731c
Gerrit-Change-Number: 13015
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>