You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/15 20:54:14 UTC

[GitHub] [tvm] Lunderberg commented on pull request #13396: [TVMScript] Use tir::Evaluate if expression is in statement context

Lunderberg commented on PR #13396:
URL: https://github.com/apache/tvm/pull/13396#issuecomment-1315851513

   This PR is in response to CI failures found in https://github.com/apache/tvm/pull/13130, when writing TVMScript that used the `T.assume()` builtin without wrapping in `T.evaluate()`.  I am updating that PR to use `T.evaluate()` in all new unit tests, but wanted to add this as a more general update.  With how TVMScript borrows heavily from Python's syntax, neither the pre-#12496 behavior of raising an error for expression statements, nor the post-#12496 behavior of ignoring expression statements felt expected as a user.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org