[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #531: PIP-250: Document proxy_version protocol update

["Anonymitaet (via GitHub)" <gi...@apache.org>]

Anonymitaet commented on code in PR #531:
URL: https://github.com/apache/pulsar-site/pull/531#discussion_r1173238073


##########
docs/developing-binary-protocol.md:
##########
@@ -145,6 +145,7 @@ Fields:
  * `original_principal`: Added by the proxy. Regular clients are not expected to supply this value. When set and when authorization is enabled, the `auth_data` must map to one of the `proxyRoles` in the broker.conf.
  * `original_auth_method`: Added by the proxy. Regular clients are not expected to supply this value.
  * `original_auth_data`: Added by the proxy when configured to do so. Regular clients are not expected to supply this value.
+ * `proxy_version`: Added by the proxy. The proxy rejects `Connect` commands with this field present. Regular clients are not expected to supply this value. When authentication and authorization are enabled in the broker, only one of the configured `proxyRoles` has permission to supply this field. In order to be backwards compatible, the broker does not require a `proxyRole` to supply this field.

Review Comment:
   ```suggestion
    * `proxy_version`: Added by the proxy. The proxy rejects `Connect` commands with this field present. Regular clients are not expected to supply this value. When authentication and authorization are enabled in the broker, only one of the configured `proxyRoles` has permission to supply this field. To be backward compatible, the broker does not require a `proxyRole` to supply this field.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org