You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mikelui (via GitHub)" <gi...@apache.org> on 2023/03/27 15:23:24 UTC
[GitHub] [arrow] mikelui opened a new pull request, #34745: [MINOR]: [Python] Respect BUILD_SHARED_LIBS cmake options
mikelui opened a new pull request, #34745:
URL: https://github.com/apache/arrow/pull/34745
### Rationale for this change
Prior 240ebb75b57bb05551c9103ec3dee11c23fd0aca , both dynamic and static libraries would be built.
After, only dynamic shared libraries were being built.
This change at least gives the user the option to build dynamic or static libs with the `BUILD_SHARED_LIBS` cmake variable
See: https://cmake.org/cmake/help/latest/command/add_library.html
### What changes are included in this PR?
CMake build change
### Are these changes tested?
Yes, build with default value, and `-DBUILD_SHARED_LIBS=OFF`
For the former, got dynamic libarrow_python libs, for the latter got static libarrow_python archive
### Are there any user-facing changes?
No, default stays the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34745: [MINOR]: [Python] Respect BUILD_SHARED_LIBS cmake options
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34745:
URL: https://github.com/apache/arrow/pull/34745#issuecomment-1485331277
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mikelui closed pull request #34745: MINOR: [Python] Respect BUILD_SHARED_LIBS cmake options
Posted by "mikelui (via GitHub)" <gi...@apache.org>.
mikelui closed pull request #34745: MINOR: [Python] Respect BUILD_SHARED_LIBS cmake options
URL: https://github.com/apache/arrow/pull/34745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34745: MINOR: [Python] Respect BUILD_SHARED_LIBS cmake options
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34745:
URL: https://github.com/apache/arrow/pull/34745#issuecomment-1485832787
This is not a minor change. Could you open an issue for this pull request and explain your use case for this?
See also:
> If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
>
> Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
>
> Then could you also rename the pull request title in the following format?
>
> ```
> GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
> ```
>
> ...
>
> See also:
>
> * [Other pull requests](https://github.com/apache/arrow/pulls/)
>
> * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mikelui commented on pull request #34745: MINOR: [Python] Respect BUILD_SHARED_LIBS cmake options
Posted by "mikelui (via GitHub)" <gi...@apache.org>.
mikelui commented on PR #34745:
URL: https://github.com/apache/arrow/pull/34745#issuecomment-1498206868
deciding this isn't valuable, for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org