You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Satoshi Kobayashi <sa...@stratosphere.co.jp> on 2012/11/19 06:24:35 UTC
Review Request: Fix for CLOUDSTACK-498 (Missing dependency in RPM of KVM
Agent)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8120/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
bridge-utils is added to RPM of KVM Agent (cloud-agent). It is necessary to operate for KVM Agent. LibvirtComputingResource class and BridgeVifDriver class execute "brctl" command internally. "brctl" command is contained in bridge-utils package.
This addresses bug CLOUDSTACK-498.
Diffs
-----
cloud.spec 29c10936a9f592a219597302300506067004cd62
Diff: https://reviews.apache.org/r/8120/diff/
Testing
-------
$ mvn install -P deps && ./waf rpm
$ rpm -qpR cloud-agent-4.0.0-1.el6.x86_64.rpm
(snip)
bridge-utils
(snip)
And it checked that installed RPM and "brctl" command existed.
$ which brctl
/usr/sbin/brctl
Thanks,
Satoshi Kobayashi
Re: Review Request: Fix for CLOUDSTACK-498 (Missing dependency in RPM of KVM
Agent)
Posted by David Nalley <da...@gnsa.us>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8120/#review13565
-----------------------------------------------------------
Ship it!
Thanks for the patch - I've committed this to master.
commit 613591d344785c09629759b9191e6ac169daac54
Author: Satoshi Kobayashi <sa...@stratosphere.co.jp>
Date: Mon Nov 19 08:55:47 2012 -0500
CLOUDSTACK-498 Missing dependency in RPMs of KVM agent
Please close this request as submitted.
- David Nalley
On Nov. 19, 2012, 5:24 a.m., Satoshi Kobayashi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8120/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2012, 5:24 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> bridge-utils is added to RPM of KVM Agent (cloud-agent). It is necessary to operate for KVM Agent. LibvirtComputingResource class and BridgeVifDriver class execute "brctl" command internally. "brctl" command is contained in bridge-utils package.
>
>
> This addresses bug CLOUDSTACK-498.
>
>
> Diffs
> -----
>
> cloud.spec 29c10936a9f592a219597302300506067004cd62
>
> Diff: https://reviews.apache.org/r/8120/diff/
>
>
> Testing
> -------
>
> $ mvn install -P deps && ./waf rpm
> $ rpm -qpR cloud-agent-4.0.0-1.el6.x86_64.rpm
> (snip)
> bridge-utils
> (snip)
>
> And it checked that installed RPM and "brctl" command existed.
> $ which brctl
> /usr/sbin/brctl
>
>
> Thanks,
>
> Satoshi Kobayashi
>
>