[jira] [Commented] (IGNITE-10023) Improve ListeningTestLogger for wait conditions.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-10023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666855#comment-16666855 ] 

ASF GitHub Bot commented on IGNITE-10023:
-----------------------------------------

GitHub user NSAmelchev opened a pull request:

    https://github.com/apache/ignite/pull/5191

    IGNITE-10023

    Improve ListeningTestLogger for wait conditions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NSAmelchev/ignite ignite-10023

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/5191.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5191
    
----
commit ee24281b9bfd0affc15f2dc2efaabf95e8062cdf
Author: NSAmelchev <ns...@...>
Date:   2018-10-29T08:39:28Z

    Improve test logger

----


> Improve ListeningTestLogger for wait conditions.
> ------------------------------------------------
>
>                 Key: IGNITE-10023
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10023
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Amelchev Nikita
>            Assignee: Amelchev Nikita
>            Priority: Major
>             Fix For: 2.8
>
>
> [Dev-list discussion.|http://apache-ignite-developers.2346864.n4.nabble.com/Unreliable-checks-in-tests-for-string-presence-in-GridStringLogger-contents-td30802.html]
> Method LogListener.check() should be boolean type.
> It'll be useful for wait for conditions and code readability:
> For now:
> {code:java}
> waitForCondition(() -> { 
>  try { 
>    lsnr.check(); 
>    return true; 
>  } 
>  catch (AssertionError ignored) { 
>    return false; 
>  } 
> }, timeout); 
> {code}
> After improvement:
> {code:java}
> waitForCondition(lsnr::check, timeout);
> {code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)