You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Caleb Rackliffe (Jira)" <ji...@apache.org> on 2022/01/11 17:52:00 UTC
[jira] [Comment Edited] (CASSANDRA-17252) ConnectionLimitHandler may leaks connection count if remote connection drops
[ https://issues.apache.org/jira/browse/CASSANDRA-17252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472985#comment-17472985 ]
Caleb Rackliffe edited comment on CASSANDRA-17252 at 1/11/22, 5:51 PM:
-----------------------------------------------------------------------
+1 on both PRs, although the 3.0 PR seems to have {{trunk}} as its base.
Also, I'm not sure WTH is going on w/ the CircleCi runs: https://app.circleci.com/pipelines/github/jonmeredith/cassandra/545/workflows/c06ad8f5-5a4d-42fe-a126-a3da09ca8149/jobs/2553
Looks like [~jmckenzie] also ran into this: https://github.com/apache/cassandra/pull/1205/commits/1598b958d7cce3a81e1a44c27f08eb0b5a4c94a4
was (Author: maedhroz):
+1 on both PRs, although the 3.0 PR seems to have {{trunk}} as its base.
Also, I'm not sure WTH is going on w/ the CircleCi runs: https://app.circleci.com/pipelines/github/jonmeredith/cassandra/545/workflows/c06ad8f5-5a4d-42fe-a126-a3da09ca8149/jobs/2553
> ConnectionLimitHandler may leaks connection count if remote connection drops
> ----------------------------------------------------------------------------
>
> Key: CASSANDRA-17252
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17252
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
> Reporter: Jon Meredith
> Assignee: Jon Meredith
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> In some cases, Netty does not return the original IP used for per-IP counting when the channel becomes inactive,
> which throws an NPE before decrementing the active per-IP count.
> {code:java}
> java.lang.NullPointerException
> at org.apache.cassandra.transport.ConnectionLimitHandler.channelInactive(ConnectionLimitHandler.java:101)
> at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262)
> at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248)
> at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:241)
> at io.netty.handler.codec.ByteToMessageDecoder.channelInputClosed(ByteToMessageDecoder.java:389)
> at io.netty.handler.codec.ByteToMessageDecoder.channelInactive(ByteToMessageDecoder.java:354)
> at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262)
> at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248)
> at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:241)
> at io.netty.channel.DefaultChannelPipeline$HeadContext.channelInactive(DefaultChannelPipeline.java:1405)
> at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262)
> at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248)
> at io.netty.channel.DefaultChannelPipeline.fireChannelInactive(DefaultChannelPipeline.java:901)
> at io.netty.channel.AbstractChannel$AbstractUnsafe$8.run(AbstractChannel.java:819)
> at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164)
> at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472)
> at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:497)
> at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
> at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
> at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.base/java.lang.Thread.run(Thread.java:834)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org