You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "jiangzho (via GitHub)" <gi...@apache.org> on 2025/11/13 01:48:18 UTC
[PR] [SPARK-54328] Add configurable startupProbe and enhance liveness/readiness probes in Helm chart [spark-kubernetes-operator]
jiangzho opened a new pull request, #417:
URL: https://github.com/apache/spark-kubernetes-operator/pull/417
### What changes were proposed in this pull request?
This PR adds a configurable `startupProbe` and enhances the existing `livenessProbe` and `readinessProbe` with additional configurable parameters in the Helm chart for the spark-kubernetes-operator.
### Why are the changes needed?
Previously, these values were either using Kubernetes defaults or not configured at all. This change makes them explicitly configurable via Helm values, giving operators more control over pod lifecycle management in different cluster environments (small clusters vs large production clusters).
### Does this PR introduce _any_ user-facing change?
Yes. Users can now configure these probe settings in their `values.yaml`
### How was this patch tested?
E2E coverage for default value, and local dry-run for value overrides
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54328] Add configurable startupProbe and enhance liveness/readiness probes in Helm chart [spark-kubernetes-operator]
Posted by "jiangzho (via GitHub)" <gi...@apache.org>.
jiangzho commented on PR #417:
URL: https://github.com/apache/spark-kubernetes-operator/pull/417#issuecomment-3530334749
Thanks for the catch! Seems GitHub interprates that as a JIRA automatically. Updated the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54328] Add configurable startupProbe and enhance liveness/readiness probes in Helm chart [spark-kubernetes-operator]
Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth commented on PR #417:
URL: https://github.com/apache/spark-kubernetes-operator/pull/417#issuecomment-3532548871
Thank you @jiangzho.
Merged to `main` (0.7.0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54328] Add configurable startupProbe and enhance liveness/readiness probes in Helm chart [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #417:
URL: https://github.com/apache/spark-kubernetes-operator/pull/417#issuecomment-3865991833
I also made a PR for https://github.com/apache/spark-kubernetes-operator/pull/417#discussion_r2778388161
- https://github.com/apache/spark-kubernetes-operator/pull/492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54328] Add configurable startupProbe and enhance liveness/readiness probes in Helm chart [spark-kubernetes-operator]
Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth closed pull request #417: [SPARK-54328] Add configurable startupProbe and enhance liveness/readiness probes in Helm chart
URL: https://github.com/apache/spark-kubernetes-operator/pull/417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54328] Add configurable startupProbe and enhance liveness/readiness probes in Helm chart [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #417:
URL: https://github.com/apache/spark-kubernetes-operator/pull/417#issuecomment-3865962709
I made a PR to fix this stability issue.
- https://github.com/apache/spark-kubernetes-operator/pull/491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54328] Add configurable startupProbe and enhance liveness/readiness probes in Helm chart [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #417:
URL: https://github.com/apache/spark-kubernetes-operator/pull/417#discussion_r2778388161
##########
build-tools/helm/spark-kubernetes-operator/values.yaml:
##########
@@ -61,9 +61,14 @@ operatorDeployment:
livenessProbe:
periodSeconds: 10
initialDelaySeconds: 30
+ failureThreshold: 1
+ timeoutSeconds: 1
startupProbe:
failureThreshold: 30
periodSeconds: 10
+ readinessProbe:
+ failureThreshold: 1
Review Comment:
Also, this PR introduces an inconsistency for `readinessProbe.failureThreahold`. Here, this PR uses 1 while the default is introduced by 30.
{{- default 30 .Values.operatorDeployment.operatorPod.operatorContainer.probes.readinessProbe.failureThreshold }}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54328] Add configurable startupProbe and enhance liveness/readiness probes in Helm chart [spark-kubernetes-operator]
Posted by "jiangzho (via GitHub)" <gi...@apache.org>.
jiangzho commented on PR #417:
URL: https://github.com/apache/spark-kubernetes-operator/pull/417#issuecomment-3524755358
cc @peter-toth for review - thanks a lot in advance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org