You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Prabhjyot Singh <pr...@gmail.com> on 2017/09/19 05:06:51 UTC

Review Request 62399: Store Zeppelin's interpreter.json in HDFS

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62399/
-----------------------------------------------------------

Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-21987
    https://issues.apache.org/jira/browse/AMBARI-21987


Repository: ambari


Description
-------

With ZEPPELIN-2742 there is a plan to store all of Note, interpreter.json, helium.json, notebook-authorization.json, and credentials.json to store in HDFS. This JIRA is to maintain its related Ambari side changes.


Diffs
-----

  ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml bd6ad76bd5 
  ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py ba73d104d6 
  ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-config.xml ca6b295159 
  ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py ba73d104d6 
  ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 815b2c0993 
  ambari-server/src/test/python/stacks/2.5/configs/default.json 36a72822b4 
  ambari-server/src/test/python/stacks/2.5/configs/secured.json b092b22ef5 
  ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.6/configs/default.json 31f3dbde71 


Diff: https://reviews.apache.org/r/62399/diff/1/


Testing
-------

Manually


Thanks,

Prabhjyot Singh


Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62399/#review185668
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On Sept. 19, 2017, 10:17 a.m., Prabhjyot Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62399/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2017, 10:17 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-21987
>     https://issues.apache.org/jira/browse/AMBARI-21987
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> With ZEPPELIN-2742 there is a plan to store all of Note, interpreter.json, helium.json, notebook-authorization.json, and credentials.json to store in HDFS. This JIRA is to maintain its related Ambari side changes.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml bd6ad76bd5 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py ba73d104d6 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-config.xml ca6b295159 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py ba73d104d6 
>   ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 815b2c0993 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json 36a72822b4 
>   ambari-server/src/test/python/stacks/2.5/configs/secured.json b092b22ef5 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json 31f3dbde71 
> 
> 
> Diff: https://reviews.apache.org/r/62399/diff/4/
> 
> 
> Testing
> -------
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>


Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62399/#review185671
-----------------------------------------------------------


Ship it!




Ship It!

- venkat sairam


On Sept. 19, 2017, 10:17 a.m., Prabhjyot Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62399/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2017, 10:17 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-21987
>     https://issues.apache.org/jira/browse/AMBARI-21987
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> With ZEPPELIN-2742 there is a plan to store all of Note, interpreter.json, helium.json, notebook-authorization.json, and credentials.json to store in HDFS. This JIRA is to maintain its related Ambari side changes.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml bd6ad76bd5 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py ba73d104d6 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-config.xml ca6b295159 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py ba73d104d6 
>   ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 815b2c0993 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json 36a72822b4 
>   ambari-server/src/test/python/stacks/2.5/configs/secured.json b092b22ef5 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json 31f3dbde71 
> 
> 
> Diff: https://reviews.apache.org/r/62399/diff/4/
> 
> 
> Testing
> -------
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>


Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

Posted by Prabhjyot Singh <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62399/
-----------------------------------------------------------

(Updated Sept. 19, 2017, 3:47 p.m.)


Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.


Changes
-------

test_zeppelin_070 should point to 0.7.0 package


Bugs: AMBARI-21987
    https://issues.apache.org/jira/browse/AMBARI-21987


Repository: ambari


Description
-------

With ZEPPELIN-2742 there is a plan to store all of Note, interpreter.json, helium.json, notebook-authorization.json, and credentials.json to store in HDFS. This JIRA is to maintain its related Ambari side changes.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml bd6ad76bd5 
  ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py ba73d104d6 
  ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-config.xml ca6b295159 
  ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py ba73d104d6 
  ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 815b2c0993 
  ambari-server/src/test/python/stacks/2.5/configs/default.json 36a72822b4 
  ambari-server/src/test/python/stacks/2.5/configs/secured.json b092b22ef5 
  ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.6/configs/default.json 31f3dbde71 


Diff: https://reviews.apache.org/r/62399/diff/4/

Changes: https://reviews.apache.org/r/62399/diff/3-4/


Testing
-------

Manually


Thanks,

Prabhjyot Singh


Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

Posted by Prabhjyot Singh <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62399/
-----------------------------------------------------------

(Updated Sept. 19, 2017, 3:19 p.m.)


Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-21987
    https://issues.apache.org/jira/browse/AMBARI-21987


Repository: ambari


Description
-------

With ZEPPELIN-2742 there is a plan to store all of Note, interpreter.json, helium.json, notebook-authorization.json, and credentials.json to store in HDFS. This JIRA is to maintain its related Ambari side changes.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml bd6ad76bd5 
  ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py ba73d104d6 
  ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-config.xml ca6b295159 
  ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py ba73d104d6 
  ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 815b2c0993 
  ambari-server/src/test/python/stacks/2.5/configs/default.json 36a72822b4 
  ambari-server/src/test/python/stacks/2.5/configs/secured.json b092b22ef5 
  ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.6/configs/default.json 31f3dbde71 


Diff: https://reviews.apache.org/r/62399/diff/3/

Changes: https://reviews.apache.org/r/62399/diff/2-3/


Testing
-------

Manually


Thanks,

Prabhjyot Singh


Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

Posted by Prabhjyot Singh <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62399/
-----------------------------------------------------------

(Updated Sept. 19, 2017, 3:18 p.m.)


Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-21987
    https://issues.apache.org/jira/browse/AMBARI-21987


Repository: ambari


Description
-------

With ZEPPELIN-2742 there is a plan to store all of Note, interpreter.json, helium.json, notebook-authorization.json, and credentials.json to store in HDFS. This JIRA is to maintain its related Ambari side changes.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml bd6ad76bd5 
  ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py ba73d104d6 
  ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-config.xml ca6b295159 
  ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py ba73d104d6 
  ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 815b2c0993 
  ambari-server/src/test/python/stacks/2.5/configs/default.json 36a72822b4 
  ambari-server/src/test/python/stacks/2.5/configs/secured.json b092b22ef5 
  ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.6/configs/default.json 31f3dbde71 


Diff: https://reviews.apache.org/r/62399/diff/2/

Changes: https://reviews.apache.org/r/62399/diff/1-2/


Testing
-------

Manually


Thanks,

Prabhjyot Singh


Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62399/#review185653
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-config.xml
Lines 90 (patched)
<https://reviews.apache.org/r/62399/#comment261977>

    Can you make this work for relative path as well?


- venkat sairam


On Sept. 19, 2017, 5:06 a.m., Prabhjyot Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62399/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2017, 5:06 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-21987
>     https://issues.apache.org/jira/browse/AMBARI-21987
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> With ZEPPELIN-2742 there is a plan to store all of Note, interpreter.json, helium.json, notebook-authorization.json, and credentials.json to store in HDFS. This JIRA is to maintain its related Ambari side changes.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml bd6ad76bd5 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py ba73d104d6 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-config.xml ca6b295159 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py ba73d104d6 
>   ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 815b2c0993 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json 36a72822b4 
>   ambari-server/src/test/python/stacks/2.5/configs/secured.json b092b22ef5 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json 31f3dbde71 
> 
> 
> Diff: https://reviews.apache.org/r/62399/diff/1/
> 
> 
> Testing
> -------
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>


Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62399/#review185652
-----------------------------------------------------------


Ship it!




Ship It!

- venkat sairam


On Sept. 19, 2017, 5:06 a.m., Prabhjyot Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62399/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2017, 5:06 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-21987
>     https://issues.apache.org/jira/browse/AMBARI-21987
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> With ZEPPELIN-2742 there is a plan to store all of Note, interpreter.json, helium.json, notebook-authorization.json, and credentials.json to store in HDFS. This JIRA is to maintain its related Ambari side changes.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml bd6ad76bd5 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py ba73d104d6 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-config.xml ca6b295159 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py ba73d104d6 
>   ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 815b2c0993 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json 36a72822b4 
>   ambari-server/src/test/python/stacks/2.5/configs/secured.json b092b22ef5 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json 31f3dbde71 
> 
> 
> Diff: https://reviews.apache.org/r/62399/diff/1/
> 
> 
> Testing
> -------
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>