You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2008/10/10 08:16:35 UTC
Re: svn commit: r33582 - trunk/subversion/include
On Thu, Oct 9, 2008 at 9:35 AM, <lg...@tigris.org> wrote:
>...
> +++ trunk/subversion/include/svn_path.h Thu Oct 9 09:35:13 2008 (r33582)
> @@ -234,12 +234,8 @@ svn_dirent_is_root(const char *dirent, a
> const char *
> svn_path_canonicalize(const char *path, apr_pool_t *pool);
>
> -/** Return @c TRUE iff path is canonical. Use @a pool for temporary
> - * allocations.
> - *
> - * @note The test for canonicalization is currently defined as
> - * "looks exactly the same as @c svn_path_canonicalize() would make
> - * it look".
> +/** Return @c TRUE iff path is canonical. The @a pool is not used and
> + * may be NULL.
The pool is used in 1.5, right? So if somebody codes to work with 1.5
and passes pool==NULL, then it'll crash.
Cheers,
-g
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r33582 - trunk/subversion/include
Posted by Lieven Govaerts <sv...@mobsol.be>.
Greg Stein wrote:
> On Thu, Oct 9, 2008 at 9:35 AM, <lg...@tigris.org> wrote:
>> ...
>> +++ trunk/subversion/include/svn_path.h Thu Oct 9 09:35:13 2008 (r33582)
>> @@ -234,12 +234,8 @@ svn_dirent_is_root(const char *dirent, a
>> const char *
>> svn_path_canonicalize(const char *path, apr_pool_t *pool);
>>
>> -/** Return @c TRUE iff path is canonical. Use @a pool for temporary
>> - * allocations.
>> - *
>> - * @note The test for canonicalization is currently defined as
>> - * "looks exactly the same as @c svn_path_canonicalize() would make
>> - * it look".
>> +/** Return @c TRUE iff path is canonical. The @a pool is not used and
>> + * may be NULL.
>
> The pool is used in 1.5, right? So if somebody codes to work with 1.5
> and passes pool==NULL, then it'll crash.
This function is to be deprecated in the near future, but you're right
nonetheless.
Lieven
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org