You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/11 06:38:11 UTC

[GitHub] [incubator-superset] zhaoyongjie opened a new pull request #10840: Adding Dashboard toggle fullscreen button

zhaoyongjie opened a new pull request #10840:
URL: https://github.com/apache/incubator-superset/pull/10840


   ### SUMMARY
   Dashboard can recieve url parameter `standalone` toggle fullscreen mode or not, expose this function to Dashboard header dropdown 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   ![image](https://user-images.githubusercontent.com/2016594/92875897-1671e700-f43c-11ea-966b-d95318c8c6a0.png)
   
   
   ### TEST PLAN
   Adding unit test to getDashboardUrl_spec.js
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on pull request #10840: Adding Dashboard toggle fullscreen button

Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #10840:
URL: https://github.com/apache/incubator-superset/pull/10840#issuecomment-691297244


   Could you attach a screenshot showing what the dashboard looks like after clicking the button?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] zhaoyongjie commented on pull request #10840: Adding Dashboard toggle fullscreen button

Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #10840:
URL: https://github.com/apache/incubator-superset/pull/10840#issuecomment-691365801


   @etr2460 HI, I append a image to PR comment. thanks for you remind


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] zhaoyongjie closed pull request #10840: Adding Dashboard toggle fullscreen button

Posted by GitBox <gi...@apache.org>.
zhaoyongjie closed pull request #10840:
URL: https://github.com/apache/incubator-superset/pull/10840


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud edited a comment on pull request #10840: Adding Dashboard toggle fullscreen button

Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #10840:
URL: https://github.com/apache/incubator-superset/pull/10840#issuecomment-693729937


   FWIW, Tableau has a Presentation Mode on desktop app, but a Full Screen button on web.
   
   <img src="https://user-images.githubusercontent.com/335541/93404206-70a8e880-f83e-11ea-97ad-9c5aa78463a9.png" 
    width="600" />
   
   They also removed the main menu on the dashboard page and replaced it with a back button.
   
   Redash, on the other hand, replace the main menu with a sidebar everywhere.  It'd be interesting to explore these nav patterns for Superset, too. But that's totally another topic.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on pull request #10840: Adding Dashboard toggle fullscreen button

Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #10840:
URL: https://github.com/apache/incubator-superset/pull/10840#issuecomment-693681191


   I think "standalone" is a better term... I would reserve "fullscreen" for some sort of `Element.requestFullscreen()` implementation... 
   
   Or, you could consider adding that functionality in this PR to make the functionality better fit the name.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] zhaoyongjie commented on pull request #10840: Adding Dashboard toggle fullscreen button

Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #10840:
URL: https://github.com/apache/incubator-superset/pull/10840#issuecomment-691365801






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10840: Adding Dashboard toggle fullscreen button

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10840:
URL: https://github.com/apache/incubator-superset/pull/10840#issuecomment-690996800


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10840?src=pr&el=h1) Report
   > Merging [#10840](https://codecov.io/gh/apache/incubator-superset/pull/10840?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/136f90f87c1d2e8f681090b044fe11f11e5652c7?el=desc) will **decrease** coverage by `0.09%`.
   > The diff coverage is `58.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10840/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10840?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10840      +/-   ##
   ==========================================
   - Coverage   65.57%   65.48%   -0.10%     
   ==========================================
     Files         809      809              
     Lines       38038    38048      +10     
     Branches     3561     3566       +5     
   ==========================================
   - Hits        24945    24915      -30     
   - Misses      12987    13024      +37     
   - Partials      106      109       +3     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.35% <50.00%> (-0.47%)` | :arrow_down: |
   | #javascript | `61.58% <58.33%> (-0.01%)` | :arrow_down: |
   | #python | `61.34% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10840?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | `68.88% <33.33%> (-5.48%)` | :arrow_down: |
   | [...set-frontend/src/dashboard/util/getDashboardUrl.js](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZFVybC5qcw==) | `88.88% <83.33%> (-11.12%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `77.27% <0.00%> (-5.20%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
   | [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.25% <0.00%> (-2.36%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.75% <0.00%> (-1.66%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `52.12% <0.00%> (-1.22%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `55.91% <0.00%> (-1.08%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10840?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10840?src=pr&el=footer). Last update [136f90f...5e8aaf5](https://codecov.io/gh/apache/incubator-superset/pull/10840?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on pull request #10840: Adding Dashboard toggle fullscreen button

Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #10840:
URL: https://github.com/apache/incubator-superset/pull/10840#issuecomment-691297244






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10840: Adding Dashboard toggle fullscreen button

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10840:
URL: https://github.com/apache/incubator-superset/pull/10840#issuecomment-690996800






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on pull request #10840: Adding Dashboard toggle fullscreen button

Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #10840:
URL: https://github.com/apache/incubator-superset/pull/10840#issuecomment-693727784


   Actually, @zhaoyongjie I'm curious what your use case is here... do you want to share the link to others in "standalone mode" or is it that you want a version for TV/presentation purposes (i.e. "presentation mode")?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10840: Adding Dashboard toggle fullscreen button

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10840:
URL: https://github.com/apache/incubator-superset/pull/10840#issuecomment-690996800






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on pull request #10840: Adding Dashboard toggle fullscreen button

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10840:
URL: https://github.com/apache/incubator-superset/pull/10840#issuecomment-693729937


   FWIW, Tableau has a Presentation Mode on desktop app, but a Full Screen button on web.
   
   <img src="https://user-images.githubusercontent.com/335541/93404206-70a8e880-f83e-11ea-97ad-9c5aa78463a9.png" 
    width="600" />
   
   They also removed the main menu on the dashboard page and replaced it with a back button.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on pull request #10840: Adding Dashboard toggle fullscreen button

Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #10840:
URL: https://github.com/apache/incubator-superset/pull/10840#issuecomment-691297244






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] zhaoyongjie commented on pull request #10840: Adding Dashboard toggle fullscreen button

Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #10840:
URL: https://github.com/apache/incubator-superset/pull/10840#issuecomment-691365801






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10840: Adding Dashboard toggle fullscreen button

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10840:
URL: https://github.com/apache/incubator-superset/pull/10840#issuecomment-690996800


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10840?src=pr&el=h1) Report
   > Merging [#10840](https://codecov.io/gh/apache/incubator-superset/pull/10840?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/136f90f87c1d2e8f681090b044fe11f11e5652c7?el=desc) will **increase** coverage by `0.02%`.
   > The diff coverage is `58.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10840/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10840?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10840      +/-   ##
   ==========================================
   + Coverage   65.57%   65.60%   +0.02%     
   ==========================================
     Files         809      809              
     Lines       38038    38216     +178     
     Branches     3561     3566       +5     
   ==========================================
   + Hits        24945    25072     +127     
   - Misses      12987    13035      +48     
   - Partials      106      109       +3     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.35% <50.00%> (-0.47%)` | :arrow_down: |
   | #javascript | `61.58% <58.33%> (-0.01%)` | :arrow_down: |
   | #python | `61.56% <ø> (+0.22%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10840?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | `68.88% <33.33%> (-5.48%)` | :arrow_down: |
   | [...set-frontend/src/dashboard/util/getDashboardUrl.js](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZFVybC5qcw==) | `88.88% <83.33%> (-11.12%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `77.27% <0.00%> (-5.20%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
   | [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.25% <0.00%> (-2.36%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.75% <0.00%> (-1.66%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `52.12% <0.00%> (-1.22%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `55.91% <0.00%> (-1.08%)` | :arrow_down: |
   | ... and [1 more](https://codecov.io/gh/apache/incubator-superset/pull/10840/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10840?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10840?src=pr&el=footer). Last update [136f90f...5e8aaf5](https://codecov.io/gh/apache/incubator-superset/pull/10840?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai merged pull request #10840: Adding Dashboard toggle fullscreen button

Posted by GitBox <gi...@apache.org>.
nytai merged pull request #10840:
URL: https://github.com/apache/incubator-superset/pull/10840


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on pull request #10840: Adding Dashboard toggle fullscreen button

Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #10840:
URL: https://github.com/apache/incubator-superset/pull/10840#issuecomment-691297244


   Could you attach a screenshot showing what the dashboard looks like after clicking the button?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] zhaoyongjie commented on pull request #10840: Adding Dashboard toggle fullscreen button

Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #10840:
URL: https://github.com/apache/incubator-superset/pull/10840#issuecomment-691365801


   @etr2460 HI, I append a image to PR comment. thanks for you remind


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org