[GitHub] [submarine] yuanzac commented on a change in pull request #187: Add yarn submitter with classloader.

[GitBox <gi...@apache.org>]

yuanzac commented on a change in pull request #187: Add yarn submitter with classloader.
URL: https://github.com/apache/submarine/pull/187#discussion_r381728290
 
 

 ##########
 File path: bin/common.sh
 ##########
 @@ -88,7 +88,7 @@ function download_mysql_jdbc_jar(){
   echo "Mysql jdbc jar is downloaded and put in the path of submarine/lib."
 }
 
-JAVA_OPTS+=" ${SUBMARINE_SERVER_JAVA_OPTS} -Dfile.encoding=UTF-8 ${SUBMARINE_SERVER_MEM}"
+JAVA_OPTS+=" -Dfile.encoding=UTF-8"
 
 Review comment:
   Because they are added in submarine-daemon.sh and submarine.sh. So we need to delete them to avoid deplications.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org