You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ma...@apache.org on 2018/05/25 09:08:59 UTC
[2/7] james-project git commit: MAILBOX-337 Solve some IntelliJ
warnings
MAILBOX-337 Solve some IntelliJ warnings
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/aa016072
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/aa016072
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/aa016072
Branch: refs/heads/master
Commit: aa01607200aaceae3c683afc079ec92a6a4fd686
Parents: de07900
Author: benwa <bt...@linagora.com>
Authored: Thu May 24 16:09:41 2018 +0700
Committer: Matthieu Baechler <ma...@apache.org>
Committed: Fri May 25 11:07:39 2018 +0200
----------------------------------------------------------------------
.../store/AbstractMessageIdManagerSideEffectTest.java | 5 ++---
.../mailbox/store/mail/model/MessageIdMapperTest.java | 14 +++++++-------
2 files changed, 9 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/james-project/blob/aa016072/mailbox/store/src/test/java/org/apache/james/mailbox/store/AbstractMessageIdManagerSideEffectTest.java
----------------------------------------------------------------------
diff --git a/mailbox/store/src/test/java/org/apache/james/mailbox/store/AbstractMessageIdManagerSideEffectTest.java b/mailbox/store/src/test/java/org/apache/james/mailbox/store/AbstractMessageIdManagerSideEffectTest.java
index 9f81ac0..cac1a73 100644
--- a/mailbox/store/src/test/java/org/apache/james/mailbox/store/AbstractMessageIdManagerSideEffectTest.java
+++ b/mailbox/store/src/test/java/org/apache/james/mailbox/store/AbstractMessageIdManagerSideEffectTest.java
@@ -44,7 +44,6 @@ import org.apache.james.mailbox.exception.OverQuotaException;
import org.apache.james.mailbox.fixture.MailboxFixture;
import org.apache.james.mailbox.mock.MockMailboxSession;
import org.apache.james.mailbox.model.FetchGroupImpl;
-import org.apache.james.mailbox.model.MailboxId;
import org.apache.james.mailbox.model.MessageId;
import org.apache.james.mailbox.model.MessageResult;
import org.apache.james.mailbox.model.Quota;
@@ -196,7 +195,7 @@ public abstract class AbstractMessageIdManagerSideEffectTest {
expectedException.expect(OverQuotaException.class);
- messageIdManager.setInMailboxes(messageId, ImmutableList.<MailboxId>of(mailbox1.getMailboxId(), mailbox2.getMailboxId()), session);
+ messageIdManager.setInMailboxes(messageId, ImmutableList.of(mailbox1.getMailboxId(), mailbox2.getMailboxId()), session);
}
@Test
@@ -260,7 +259,7 @@ public abstract class AbstractMessageIdManagerSideEffectTest {
MessageId messageId = testingData.persist(mailbox1.getMailboxId(), messageUid1, FLAGS, session);
reset(dispatcher);
- messageIdManager.setFlags(newFlags, MessageManager.FlagsUpdateMode.ADD, messageId, ImmutableList.<MailboxId>of(), session);
+ messageIdManager.setFlags(newFlags, MessageManager.FlagsUpdateMode.ADD, messageId, ImmutableList.of(), session);
verifyNoMoreInteractions(dispatcher);
}
http://git-wip-us.apache.org/repos/asf/james-project/blob/aa016072/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/MessageIdMapperTest.java
----------------------------------------------------------------------
diff --git a/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/MessageIdMapperTest.java b/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/MessageIdMapperTest.java
index badf740..afafc1d 100644
--- a/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/MessageIdMapperTest.java
+++ b/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/MessageIdMapperTest.java
@@ -102,8 +102,8 @@ public abstract class MessageIdMapperTest {
}
@Test
- public void findShouldReturnEmptyWhenIdListIsEmpty() throws MailboxException {
- assertThat(sut.find(ImmutableList.<MessageId>of(), FetchType.Full)).isEmpty();
+ public void findShouldReturnEmptyWhenIdListIsEmpty() {
+ assertThat(sut.find(ImmutableList.of(), FetchType.Full)).isEmpty();
}
@Test
@@ -128,7 +128,7 @@ public abstract class MessageIdMapperTest {
}
@Test
- public void findMailboxesShouldReturnEmptyWhenMessageDoesntExist() throws MailboxException {
+ public void findMailboxesShouldReturnEmptyWhenMessageDoesntExist() {
assertThat(sut.findMailboxes(mapperProvider.generateMessageId())).isEmpty();
}
@@ -318,7 +318,7 @@ public abstract class MessageIdMapperTest {
sut.save(message1InOtherMailbox);
MessageId messageId = message1.getMessageId();
- sut.delete(messageId, ImmutableList.<MailboxId>of());
+ sut.delete(messageId, ImmutableList.of());
List<MailboxId> mailboxes = sut.findMailboxes(messageId);
assertThat(mailboxes).containsOnly(benwaInboxMailbox.getMailboxId(), benwaWorkMailbox.getMailboxId());
@@ -467,7 +467,7 @@ public abstract class MessageIdMapperTest {
MessageId messageId = message1.getMessageId();
Flags newFlags = new Flags(Flag.ANSWERED);
- Map<MailboxId, UpdatedFlags> flags = sut.setFlags(messageId, ImmutableList.<MailboxId>of(), newFlags, FlagsUpdateMode.REMOVE);
+ Map<MailboxId, UpdatedFlags> flags = sut.setFlags(messageId, ImmutableList.of(), newFlags, FlagsUpdateMode.REMOVE);
assertThat(flags).isEmpty();
}
@@ -562,7 +562,7 @@ public abstract class MessageIdMapperTest {
MessageId messageId = message1.getMessageId();
Flags newFlags = new Flags(Flag.ANSWERED);
- sut.setFlags(messageId, ImmutableList.<MailboxId>of(), newFlags, FlagsUpdateMode.REMOVE);
+ sut.setFlags(messageId, ImmutableList.of(), newFlags, FlagsUpdateMode.REMOVE);
List<MailboxMessage> messages = sut.find(ImmutableList.of(messageId), MessageMapper.FetchType.Body);
assertThat(messages).hasSize(1);
@@ -595,7 +595,7 @@ public abstract class MessageIdMapperTest {
MessageId messageId = message1.getMessageId();
Flags newFlags = new Flags(Flag.ANSWERED);
- sut.setFlags(messageId, ImmutableList.<MailboxId>of(), newFlags, FlagsUpdateMode.REMOVE);
+ sut.setFlags(messageId, ImmutableList.of(), newFlags, FlagsUpdateMode.REMOVE);
List<MailboxMessage> messages = sut.find(ImmutableList.of(messageId), MessageMapper.FetchType.Body);
assertThat(messages).hasSize(1);
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org