You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by knusbaum <gi...@git.apache.org> on 2016/10/31 22:08:35 UTC
[GitHub] storm pull request #1752: STORM-2180: KafkaSpout ack() should handle re-bala...
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1752
STORM-2180: KafkaSpout ack() should handle re-balance
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm STORM-2180
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1752.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1752
----
commit 3ac3b8329121c38de774e57f694882eac9d1f043
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2016-10-31T21:05:44Z
Fixing KafkaSpout acking.
commit 2d3d7b109094fe966abd83f12e1ed388075b3be5
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2016-10-31T21:11:18Z
Fixing spacing.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1752: STORM-2180: KafkaSpout ack() should handle re-bala...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum closed the pull request at:
https://github.com/apache/storm/pull/1752
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1752: STORM-2180: KafkaSpout ack() should handle re-balance
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1752
Looking at the code #1696 is a much more complete solutions. @knusbaum could you take a look at it and let us know what you think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1752: STORM-2180: KafkaSpout ack() should handle re-balance
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1752
Fine by me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1752: STORM-2180: KafkaSpout ack() should handle re-balance
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1752
This is also fixed by https://github.com/apache/storm/pull/1696, please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---