You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "agam-99 (via GitHub)" <gi...@apache.org> on 2026/03/30 06:42:05 UTC
[PR] Skip directory entries in RecursiveCopyableDataset to fix IOException on empty source dirs [gobblin]
agam-99 opened a new pull request, #4181:
URL: https://github.com/apache/gobblin/pull/4181
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXXX
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
`RecursiveCopyableDataset.getCopyableFilesImpl` iterates over `filesInSource` entries and calls
`CopyableFile.resolveReplicatedOwnerAndPermissionsRecursively(fs, file.getPath().getParent(), replacedPrefix, ...)`
for each. This method requires `replacedPrefix` to be an ancestor of `file.getPath().getParent()`.
When `source.path` points to an **empty directory**, `FileListUtils.listFilesToCopyAtPath`
(with `includeEmptyDirectories=true`) returns the directory itself as the sole `FileStatus` entry.
For this entry `file.getPath() == replacedPrefix`, so `file.getPath().getParent()` is one level
*above* `replacedPrefix`. This inverts the ancestry check and throws:
IOException: toPath /source must be an ancestor of fromPath /
**Fix:** Skip `FileStatus` entries where `isDirectory=true` before attempting permission resolution.
Empty source directories produce no copy work units by design — directory creation at the destination
is handled implicitly when files are published into them. A `WARN`-level log is emitted so operators
can diagnose misconfigured source paths.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Added two tests to `RecursiveCopyableDatasetTest`:
- `testEmptySourceDirectoryProducesNoCopyEntities` — verifies that when `filesInSource` contains only
the empty-directory entry (the exact condition that triggered the bug), `getCopyableFiles` returns
zero copy entities rather than throwing `IOException`
- `testMixedSourceWithDirectoryEntrySkipsDirectories` — verifies that when a directory entry is mixed
in with real files, the real files are copied and the directory entry is silently skipped
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits
if they address the same issue. In addition, my commits follow the guidelines from
"[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Skip directory entries in RecursiveCopyableDataset to fix IOException on empty source dirs [gobblin]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4181:
URL: https://github.com/apache/gobblin/pull/4181#issuecomment-4205056546
## [Codecov](https://app.codecov.io/gh/apache/gobblin/pull/4181?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 43.30%. Comparing base ([`26406a8`](https://app.codecov.io/gh/apache/gobblin/commit/26406a863688e289063e92bd421bf866f84e5586?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2852359`](https://app.codecov.io/gh/apache/gobblin/commit/285235905ff47c73a120a4b7aea897821095cc71?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4181 +/- ##
============================================
+ Coverage 43.26% 43.30% +0.03%
- Complexity 2583 2587 +4
============================================
Files 516 516
Lines 22087 22101 +14
Branches 2505 2505
============================================
+ Hits 9557 9570 +13
- Misses 11566 11569 +3
+ Partials 964 962 -2
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/gobblin/pull/4181?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Skip directory entries in RecursiveCopyableDataset to fix IOException on empty source dirs [gobblin]
Posted by "Blazer-007 (via GitHub)" <gi...@apache.org>.
Blazer-007 merged PR #4181:
URL: https://github.com/apache/gobblin/pull/4181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org